Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: Source/bindings/tests/idls/TestObject.idl

Issue 232563003: API functions returning Promises should not throw exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/idls/TestObject.idl
diff --git a/Source/bindings/tests/idls/TestObject.idl b/Source/bindings/tests/idls/TestObject.idl
index bbe9ff6e46072102dbd510a599645157107d654a..00994e9895c392112c2f20e6dc35813c9a7d3f62 100644
--- a/Source/bindings/tests/idls/TestObject.idl
+++ b/Source/bindings/tests/idls/TestObject.idl
@@ -366,7 +366,8 @@ interface TestObject {
// Exceptional types
Dictionary dictionaryMethod();
NodeFilter nodeFilterMethod();
- Promise promiseMethod();
+ Promise promiseMethod(long arg1, Dictionary arg2, DOMString arg3, DOMString... variadic);
bashi 2014/07/31 02:02:24 Is it possible to use enums instead of Dictionary
yhirano 2014/07/31 03:38:03 Can you tell me your plan? I added Dictionary test
bashi 2014/07/31 04:38:42 In my plan, Dictionary will be replaced by specifi
yhirano 2014/08/01 03:52:54 Thank you. Let me leave it be to keep the test cov
+ Promise promiseMethodWithoutExceptionState(Dictionary arg1);
SerializedScriptValue serializedScriptValueMethod();
XPathNSResolver xPathNSResolverMethod();
void voidMethodDictionaryArg(Dictionary dictionaryArg);

Powered by Google App Engine
This is Rietveld 408576698