Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: Source/core/testing/Internals.cpp

Issue 232563003: API functions returning Promises should not throw exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index d7b34e691b3d190906e36234d1bdc8f9c2534741..127d37cc4b481db244d828624f2b58ed1abfe901 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -2442,6 +2442,24 @@ ScriptPromise Internals::addOneToPromise(ExecutionContext* context, ScriptPromis
return promise.then(AddOneFunction::create(context));
}
+ScriptPromise Internals::promiseCheck(ExecutionContext* context, long arg1, bool arg2, const Dictionary& arg3, const String& arg4, ExceptionState& es)
haraken 2014/04/11 13:57:13 es => exceptionState
yhirano 2014/04/14 01:03:37 Done.
+{
+ if (arg2)
+ return ScriptPromise::cast(v8String(toIsolate(context), "done"), toIsolate(context));
+ es.throwDOMException(InvalidStateError, "Thrown from the native implementation.");
+ return ScriptPromise();
+}
+
+ScriptPromise Internals::promiseCheckWithoutExceptionState(ExecutionContext* context, const Dictionary& arg1, const String& arg2, const Vector<String>& arg3)
+{
+ return ScriptPromise::cast(v8String(toIsolate(context), "done"), toIsolate(context));
+}
+
+ScriptPromise Internals::promiseCheckRange(ExecutionContext* context, long arg1)
+{
+ return ScriptPromise::cast(v8String(toIsolate(context), "done"), toIsolate(context));
+}
+
void Internals::trace(Visitor* visitor)
{
visitor->trace(m_frontendWindow);

Powered by Google App Engine
This is Rietveld 408576698