API functions returning Promises should not throw exceptions.

Source/bindings/core/v8/ScriptPromise.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef ScriptPromise_h
 #define ScriptPromise_h
 
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptValue.h"
+#include "bindings/core/v8/V8ThrowException.h"
 #include "platform/heap/Handle.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/PassRefPtr.h"
+#include "wtf/text/WTFString.h"
 #include <v8.h>
 
 namespace blink {
 
 class DOMException;
+class ExceptionState;
 
 // ScriptPromise is the class for representing Promise values in C++ world.
 // ScriptPromise holds a Promise.
 // So holding a ScriptPromise as a member variable in DOM object causes
 // memory leaks since it has a reference from C++ to V8.
 //
 class ScriptPromise FINAL {
 public:
     // Constructs an empty promise.
     ScriptPromise() { }
@@ skipping 54 matching lines @@
     // resolved with |value|.
     // Returns |value| itself if it is a Promise.
     static ScriptPromise cast(ScriptState*, const ScriptValue& /*value*/);
     static ScriptPromise cast(ScriptState*, v8::Handle<v8::Value> /*value*/);
 
     static ScriptPromise reject(ScriptState*, const ScriptValue&);
     static ScriptPromise reject(ScriptState*, v8::Handle<v8::Value>);
 
     static ScriptPromise rejectWithDOMException(ScriptState*, PassRefPtrWillBeRawPtr<DOMException>);
 
+    // static functions each of which returns a ScriptPromise rejected with

[haraken, 2014/08/01 17:04:24]

Add a FIXME to remove these functions.

[yhirano, 2014/08/04 01:42:08]

Done.

+    // the given error.
+    // They coresspond to functions in V8Binding.h, such as throwError,
+    // throwTypeError, etc.
+    static ScriptPromise rejectWithError(ScriptState*, V8ErrorType, const String&);
+    static ScriptPromise rejectWithTypeError(ScriptState*, const String&);
+    static ScriptPromise rejectWithArityTypeErrorForMethod(ScriptState*, const char* method, const char* type, const char* valid, unsigned provided);
+    static ScriptPromise rejectWithArityTypeErrorForConstructor(ScriptState*, const char* type, const char* valid, unsigned provided);
+    static ScriptPromise rejectWithArityTypeError(ScriptState*, ExceptionState&, const char* valid, unsigned provided);
+    static ScriptPromise rejectWithMinimumArityTypeErrorForMethod(
+        ScriptState*, const char* method, const char* type, unsigned expected, unsigned providedLeastNumMandatoryParams);
+    static ScriptPromise rejectWithMinimumArityTypeErrorForConstructor(
+        ScriptState*, const char* type, unsigned expected, unsigned providedLeastNumMandatoryParams);
+    static ScriptPromise rejectWithMinimumArityTypeError(ScriptState*, ExceptionState&, unsigned expected, unsigned providedLeastNumMandatoryParams);
+
+    static v8::Local<v8::Promise> rejectRaw(v8::Isolate*, v8::Handle<v8::Value>);
+
     // This is a utility class intended to be used internally.
     // ScriptPromiseResolver is for general purpose.
     class InternalResolver FINAL {
     public:
         explicit InternalResolver(ScriptState*);
         v8::Local<v8::Promise> v8Promise() const;
         ScriptPromise promise() const;
         void resolve(v8::Local<v8::Value>);
         void reject(v8::Local<v8::Value>);
         void clear() { m_resolver.clear(); }
 
     private:
         ScriptValue m_resolver;
     };
 
 private:
     RefPtr<ScriptState> m_scriptState;
     ScriptValue m_promise;
 };
 
 } // namespace blink
 
 
 #endif // ScriptPromise_h