API functions returning Promises should not throw exceptions.

Source/bindings/core/v8/V8BindingMacros.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
     type var;                                      \
     {                                              \
         v8::TryCatch block;                        \
         var = (value);                             \
         if (UNLIKELY(block.HasCaught())) {         \
             block.ReThrow();                       \
             return retVal;                         \
         }                                          \
     }
 
+#define TONATIVE_VOID_ASYNC_INTERNAL(var, value, info)                                          \
+    var = (value);                                                                              \
+    if (UNLIKELY(block.HasCaught())) {                                                          \
+        v8SetReturnValue(info, ScriptPromise::rejectRaw(info.GetIsolate(), block.Exception())); \
+        rethrow.cancel();                                                                       \
+        return;                                                                                 \
+    }
+
+#define TONATIVE_VOID_ASYNC(type, var, value, info)     \
+    type var;                                           \
+    {                                                   \
+        v8::TryCatch block;                             \
+        V8RethrowTryCatchScope rethrow(block);          \

[haraken, 2014/07/31 07:54:47]

Do we need this? It looks redundant to set a V8RethrowTryCatchScope and cancel
it later.

[yhirano, 2014/08/01 02:27:57]

We need this to reuse the x_ASYNC_INTERNAL macro in a x_ASYNC macro.
I can delete it if I expand the x_ASYNC_INTERNAL macro.
What do you think?

[haraken, 2014/08/01 02:42:40]

Makes sense. Let's keep the x_ASYNC_INTERNAL macro as is for consistency with
other INTERNAL macros.

+        TONATIVE_VOID_ASYNC_INTERNAL(var, value, info); \
+    }
+
+
 #define TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(var, value, exceptionState) \
     var = (value);                                                        \
     if (UNLIKELY(block.HasCaught() || exceptionState.throwIfNeeded()))    \
         return;                                                           \
 
 #define TONATIVE_VOID_EXCEPTIONSTATE(type, var, value, exceptionState)     \
     type var;                                                              \
     {                                                                      \
         v8::TryCatch block;                                                \
         V8RethrowTryCatchScope rethrow(block);                             \
         TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(var, value, exceptionState); \
     }
 
 #define TONATIVE_DEFAULT_EXCEPTIONSTATE(type, var, value, exceptionState, retVal) \
     type var;                                                                     \
     {                                                                             \
         v8::TryCatch block;                                                       \
         V8RethrowTryCatchScope rethrow(block);                                    \
         var = (value);                                                            \
         if (UNLIKELY(block.HasCaught() || exceptionState.throwIfNeeded()))        \
             return retVal;                                                        \
     }
 
+#define TONATIVE_VOID_EXCEPTIONSTATE_ASYNC_INTERNAL(scriptState, var, value, exceptionState, info) \
+    var = (value);                                                                                 \
+    if (UNLIKELY(block.HasCaught())) {                                                             \
+        v8SetReturnValue(info, ScriptPromise::rejectRaw(info.GetIsolate(), block.Exception()));    \
+        rethrow.cancel();                                                                          \

[haraken, 2014/07/31 07:54:47]

Shall we add a comment and mention why we need to cancel it?

[yhirano, 2014/08/01 02:27:57]

Done.

+        return;                                                                                    \
+    }                                                                                              \
+    if (UNLIKELY(exceptionState.hadException())) {                                                 \
+        v8SetReturnValue(info, exceptionState.reject(scriptState).v8Value());                      \
+        return;                                                                                    \
+    }
+
+#define TONATIVE_VOID_EXCEPTIONSTATE_ASYNC(scriptState, type, var, value, exceptionState, info) \
+    type var;                                                                                   \
+    {                                                                                           \
+        v8::TryCatch block;                                                                     \
+        V8RethrowTryCatchScope rethrow(block);                                                  \
+        TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(scriptState, var, value, exceptionState, info);   \

[haraken, 2014/07/31 07:54:47]

Why doesn't this call TONATIVE_VOID_EXCEPTIONSTATE_ASYNC_INTERNAL?

[yhirano, 2014/08/01 02:27:57]

You're right. Thanks, done.

+    }
+
 // type is an instance of class template V8StringResource<>,
 // but Mode argument varies; using type (not Mode) for consistency
 // with other macros and ease of code generation
 #define TOSTRING_VOID(type, var, value) \
     type var(value);                    \
     if (UNLIKELY(!var.prepare()))       \
         return;
 
 #define TOSTRING_VOID_INTERNAL(var, value) \
     var = (value);                         \
     if (UNLIKELY(!var.prepare()))          \
         return;
 
 #define TOSTRING_DEFAULT(type, var, value, retVal) \
     type var(value);                               \
     if (UNLIKELY(!var.prepare()))                  \
         return retVal;
 
+#define TOSTRING_VOID_ASYNC_INTERNAL(var, value, info)                                             \
+    var = (value);                                                                                 \
+    if (UNLIKELY(!var.prepare()))  {                                                               \
+        rethrow.cancel();                                                                          \

[haraken, 2014/07/31 07:54:47]

Just for consistency, let's move rethrow.cancel() to below line 155.

[yhirano, 2014/08/01 02:27:57]

Done.

+        info.GetReturnValue().Set(ScriptPromise::rejectRaw(info.GetIsolate(), block.Exception())); \
+        return;                                                                                    \
+    }
+
+#define TOSTRING_VOID_ASYNC(type, var, value, info)           \
+    type var;                                                 \
+    {                                                         \
+        v8::TryCatch block;                                   \
+        V8RethrowTryCatchScope rethrow(block);                \
+        TOSTRING_VOID_ASYNC_INTERNAL(type, var, value, info); \
+    }
+
 } // namespace blink
 
 #endif // V8BindingMacros_h