Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 232563002: Reverting r170175: "Refactoring MatchRanges and RuleRange." (Closed)

Created:
6 years, 8 months ago by tasak
Modified:
6 years, 8 months ago
Reviewers:
esprehn
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Reverting r170175: "Refactoring MatchRanges and RuleRange." r170175 causes lots of crashes and also causes regressions reported in crbug.com/361354. > Refactoring MatchRanges and RuleRange. > > TEST=no new tests, just refactoring. > BUG=172051 > > Review URL: https://codereview.chromium.org/214333003 > > git-svn-id: svn://svn.chromium.org/blink/trunk@170175 bbb929c8-8fbe-4397-9dbb-9b2b20218538 BUG=361354, 361937 TBR=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171239

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -86 lines) Patch
M Source/core/css/ElementRuleCollector.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M Source/core/css/resolver/MatchResult.h View 2 chunks +21 lines, -51 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 14 chunks +33 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tasak
The CQ bit was checked by tasak@google.com
6 years, 8 months ago (2014-04-10 06:38:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/232563002/1
6 years, 8 months ago (2014-04-10 06:38:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 06:39:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-10 06:39:09 UTC) #4
tasak
The CQ bit was checked by tasak@google.com
6 years, 8 months ago (2014-04-10 06:41:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/232563002/1
6 years, 8 months ago (2014-04-10 06:41:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 06:42:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-10 06:43:00 UTC) #8
tasak
6 years, 8 months ago (2014-04-10 07:17:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r171239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698