Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: ui/android/resources/resource_manager_impl.h

Issue 2325623003: Replace IDMap with std::unordered_map in ResourceManager (Closed)
Patch Set: nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/android/resources/resource_manager.h ('k') | ui/android/resources/resource_manager_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_ANDROID_RESOURCES_RESOURCE_MANAGER_IMPL_H_ 5 #ifndef UI_ANDROID_RESOURCES_RESOURCE_MANAGER_IMPL_H_
6 #define UI_ANDROID_RESOURCES_RESOURCE_MANAGER_IMPL_H_ 6 #define UI_ANDROID_RESOURCES_RESOURCE_MANAGER_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/id_map.h"
11 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "third_party/skia/include/core/SkColor.h"
12 #include "ui/android/resources/resource_manager.h" 12 #include "ui/android/resources/resource_manager.h"
13 #include "ui/android/ui_android_export.h" 13 #include "ui/android/ui_android_export.h"
14 #include "ui/gfx/geometry/rect.h" 14 #include "ui/gfx/geometry/rect.h"
15 #include "ui/gfx/native_widget_types.h" 15 #include "ui/gfx/native_widget_types.h"
16 16
17 namespace cc { 17 namespace cc {
18 class UIResourceManager; 18 class UIResourceManager;
19 } // namespace cc 19 } // namespace cc
20 20
21 namespace ui { 21 namespace ui {
22 22
23 class UI_ANDROID_EXPORT ResourceManagerImpl : public ResourceManager { 23 class UI_ANDROID_EXPORT ResourceManagerImpl : public ResourceManager {
24 public: 24 public:
25 static ResourceManagerImpl* FromJavaObject(jobject jobj); 25 static ResourceManagerImpl* FromJavaObject(jobject jobj);
26 26
27 explicit ResourceManagerImpl(gfx::NativeWindow native_window); 27 explicit ResourceManagerImpl(gfx::NativeWindow native_window);
28 ~ResourceManagerImpl() override; 28 ~ResourceManagerImpl() override;
29 29
30 void Init(cc::UIResourceManager* ui_resource_manager); 30 void Init(cc::UIResourceManager* ui_resource_manager);
31 31
32 // ResourceManager implementation. 32 // ResourceManager implementation.
33 base::android::ScopedJavaLocalRef<jobject> GetJavaObject() override; 33 base::android::ScopedJavaLocalRef<jobject> GetJavaObject() override;
34 Resource* GetResource(AndroidResourceType res_type, int res_id) override; 34 Resource* GetResource(AndroidResourceType res_type, int res_id) override;
35 Resource* GetStaticResourceWithTint( 35 Resource* GetStaticResourceWithTint(
36 int res_id, int tint_color) override; 36 int res_id, SkColor tint_color) override;
37 void RemoveUnusedTints(const std::unordered_set<int>& used_tints) override; 37 void RemoveUnusedTints(const std::unordered_set<int>& used_tints) override;
38 void PreloadResource(AndroidResourceType res_type, int res_id) override; 38 void PreloadResource(AndroidResourceType res_type, int res_id) override;
39 CrushedSpriteResource* GetCrushedSpriteResource( 39 CrushedSpriteResource* GetCrushedSpriteResource(
40 int bitmap_res_id, int metadata_res_id) override; 40 int bitmap_res_id, int metadata_res_id) override;
41 41
42 // Called from Java 42 // Called from Java
43 // ---------------------------------------------------------- 43 // ----------------------------------------------------------
44 void OnResourceReady(JNIEnv* env, 44 void OnResourceReady(JNIEnv* env,
45 const base::android::JavaRef<jobject>& jobj, 45 const base::android::JavaRef<jobject>& jobj,
46 jint res_type, 46 jint res_type,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 83
84 // Start loading the resource. virtual for testing. 84 // Start loading the resource. virtual for testing.
85 virtual void PreloadResourceFromJava(AndroidResourceType res_type, 85 virtual void PreloadResourceFromJava(AndroidResourceType res_type,
86 int res_id); 86 int res_id);
87 virtual void RequestResourceFromJava(AndroidResourceType res_type, 87 virtual void RequestResourceFromJava(AndroidResourceType res_type,
88 int res_id); 88 int res_id);
89 virtual void RequestCrushedSpriteResourceFromJava(int bitmap_res_id, 89 virtual void RequestCrushedSpriteResourceFromJava(int bitmap_res_id,
90 int metadata_res_id, 90 int metadata_res_id,
91 bool reloading); 91 bool reloading);
92 92
93 typedef IDMap<Resource, IDMapOwnPointer> ResourceMap; 93 using ResourceMap = std::unordered_map<int, std::unique_ptr<Resource>>;
94 typedef IDMap<CrushedSpriteResource, IDMapOwnPointer> 94 using CrushedSpriteResourceMap =
95 CrushedSpriteResourceMap; 95 std::unordered_map<int, std::unique_ptr<CrushedSpriteResource>>;
96 typedef std::unordered_map<int, std::unique_ptr<ResourceMap> > 96 using TintedResourceMap =
97 TintedResourceMap; 97 std::unordered_map<SkColor, std::unique_ptr<ResourceMap>>;
98 98
99 cc::UIResourceManager* ui_resource_manager_; 99 cc::UIResourceManager* ui_resource_manager_;
100 ResourceMap resources_[ANDROID_RESOURCE_TYPE_COUNT]; 100 ResourceMap resources_[ANDROID_RESOURCE_TYPE_COUNT];
101 CrushedSpriteResourceMap crushed_sprite_resources_; 101 CrushedSpriteResourceMap crushed_sprite_resources_;
102 TintedResourceMap tinted_resources_; 102 TintedResourceMap tinted_resources_;
103 103
104 base::android::ScopedJavaGlobalRef<jobject> java_obj_; 104 base::android::ScopedJavaGlobalRef<jobject> java_obj_;
105 105
106 DISALLOW_COPY_AND_ASSIGN(ResourceManagerImpl); 106 DISALLOW_COPY_AND_ASSIGN(ResourceManagerImpl);
107 }; 107 };
108 108
109 } // namespace ui 109 } // namespace ui
110 110
111 #endif // UI_ANDROID_RESOURCES_RESOURCE_MANAGER_IMPL_H_ 111 #endif // UI_ANDROID_RESOURCES_RESOURCE_MANAGER_IMPL_H_
OLDNEW
« no previous file with comments | « ui/android/resources/resource_manager.h ('k') | ui/android/resources/resource_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698