Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 2325603003: [css-grid] Fix a dangling reference (Closed)

Created:
4 years, 3 months ago by svillar
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, svillar, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix a dangling reference The code was making a reference to an attribute of a temporary object created by gridTrackSize(). BUG=641982 Committed: https://crrev.com/eac7349745d4d88c888718f54f40c13aa3132085 Cr-Commit-Position: refs/heads/master@{#417309}

Patch Set 1 #

Patch Set 2 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
svillar
4 years, 3 months ago (2016-09-08 14:53:22 UTC) #2
cbiesinger
lgtm
4 years, 3 months ago (2016-09-08 15:04:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325603003/20001
4 years, 3 months ago (2016-09-08 15:12:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 16:38:11 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:40:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eac7349745d4d88c888718f54f40c13aa3132085
Cr-Commit-Position: refs/heads/master@{#417309}

Powered by Google App Engine
This is Rietveld 408576698