Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2325573003: [css-grid] Avoid computing available space if gap is not a percentage (Closed)

Created:
4 years, 3 months ago by Manuel Rego
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, svillar, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Avoid computing available space if gap is not a percentage This patch modifies LayoutGrid::gridGapForDirection() because we only need to calculate the available space if the grid gap is a percentage. Otherwise we can skip this operation. BUG=615248 Committed: https://crrev.com/b72a2612ebdee71a9114d184d970a5844c6e7c38 Cr-Commit-Position: refs/heads/master@{#417568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
This is just a simple patch after: https://codereview.chromium.org/2323793002/
4 years, 3 months ago (2016-09-09 08:14:52 UTC) #2
svillar
lgtm
4 years, 3 months ago (2016-09-09 10:17:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325573003/1
4 years, 3 months ago (2016-09-09 11:39:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 13:00:17 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 13:03:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b72a2612ebdee71a9114d184d970a5844c6e7c38
Cr-Commit-Position: refs/heads/master@{#417568}

Powered by Google App Engine
This is Rietveld 408576698