Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2325533002: Make per-bot swarming_dimensions an array. (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Zhenyao Mo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make per-bot swarming_dimensions an array. This is in preparation for deploying the Mac ASAN bot, which will spawn jobs on multiple GPU types. Add "can_use_on_swarming_builders" flag for non-swarmed tab_capture_end2end_tests. This CL is a no-op with regard to the generated JSON files. The next CL will add the new builder/tester. BUG=644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,maruel@chromium.org NOTRY=true Committed: https://crrev.com/18144abd2d8ece7820f95425faf30aa8a0fa3921 Cr-Commit-Position: refs/heads/master@{#417178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -234 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 24 chunks +335 lines, -234 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ken Russell (switch to Gerrit)
Dirk, M-A: FYI. I'm CQ'ing this TBR'd and NOTRY to have this change separate in ...
4 years, 3 months ago (2016-09-08 03:09:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325533002/1
4 years, 3 months ago (2016-09-08 03:10:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 03:34:44 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/18144abd2d8ece7820f95425faf30aa8a0fa3921 Cr-Commit-Position: refs/heads/master@{#417178}
4 years, 3 months ago (2016-09-08 03:37:06 UTC) #10
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-08 22:08:48 UTC) #11
M-A Ruel
4 years, 3 months ago (2016-09-09 13:08:14 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698