Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 232553004: Do not use ranges after range analysis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-361608.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 172
173 bool LGoto::HasInterestingComment(LCodeGen* gen) const { 173 bool LGoto::HasInterestingComment(LCodeGen* gen) const {
174 return !gen->IsNextEmittedBlock(block_id()); 174 return !gen->IsNextEmittedBlock(block_id());
175 } 175 }
176 176
177 177
178 template<int R> 178 template<int R>
179 bool LTemplateResultInstruction<R>::MustSignExtendResult( 179 bool LTemplateResultInstruction<R>::MustSignExtendResult(
180 LPlatformChunk* chunk) const { 180 LPlatformChunk* chunk) const {
181 HValue* hvalue = this->hydrogen_value(); 181 HValue* hvalue = this->hydrogen_value();
182 182 return hvalue != NULL &&
183 if (hvalue == NULL) return false; 183 hvalue->representation().IsInteger32() &&
184 if (!hvalue->representation().IsInteger32()) return false; 184 chunk->GetDehoistedKeyIds()->Contains(hvalue->id());
185 if (hvalue->HasRange() && !hvalue->range()->CanBeNegative()) return false;
186
187 return chunk->GetDehoistedKeyIds()->Contains(hvalue->id());
188 } 185 }
189 186
190 187
191 void LGoto::PrintDataTo(StringStream* stream) { 188 void LGoto::PrintDataTo(StringStream* stream) {
192 stream->Add("B%d", block_id()); 189 stream->Add("B%d", block_id());
193 } 190 }
194 191
195 192
196 void LBranch::PrintDataTo(StringStream* stream) { 193 void LBranch::PrintDataTo(StringStream* stream) {
197 stream->Add("B%d | B%d on ", true_block_id(), false_block_id()); 194 stream->Add("B%d | B%d on ", true_block_id(), false_block_id());
(...skipping 2405 matching lines...) Expand 10 before | Expand all | Expand 10 after
2603 LOperand* index = UseTempRegister(instr->index()); 2600 LOperand* index = UseTempRegister(instr->index());
2604 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2601 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2605 LInstruction* result = DefineSameAsFirst(load); 2602 LInstruction* result = DefineSameAsFirst(load);
2606 return AssignPointerMap(result); 2603 return AssignPointerMap(result);
2607 } 2604 }
2608 2605
2609 2606
2610 } } // namespace v8::internal 2607 } } // namespace v8::internal
2611 2608
2612 #endif // V8_TARGET_ARCH_X64 2609 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-361608.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698