Issue 232553004: Do not use ranges after range analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232553004: Do not use ranges after range analysis. (Closed)

Created:
6 years, 8 months ago by Sven Panne

Modified:
6 years, 8 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Do not use ranges after range analysis. Due to the SSA vs. SSI difference, we are only allowed to use the flags computed during range analysis, not the ranges themselves. For the case at hand, there is no such flag, so the condition is simply remvoed. BUG=361608 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20645

Patch Set 1 #

Patch Set 2 : Rebased. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
	M	src/x64/lithium-x64.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-361608.js	View		1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 8 months ago (2014-04-10 09:40:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20645 (presubmit successful).

Expand Messages | Collapse Messages