Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2325513002: Reland "Delete lots of svn logic from bot_update" (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland "Delete lots of svn logic from bot_update" This is a reland of 082267a659f94bf7bca5cb144e203ca0913abb3a which was reverted in 4dcad385f4b2d8a497affeea4c767910e1bc100b BUG=472386 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3454ae85da8913a18a67adaaf8727fa9783127d3

Patch Set 1 : Re-upload #

Patch Set 2 : Rebase #

Patch Set 3 : Fix error which caused purpleness #

Patch Set 4 : Comply with bot_update_coverage_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -360 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 1 2 3 26 chunks +37 lines, -351 lines 0 comments Download
M tests/bot_update_coverage_test.py View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
agable
PTAL. The first patchset is a raw re-upload of the original; the second is a ...
4 years, 3 months ago (2016-09-09 00:03:19 UTC) #5
Ryan Tseng
lgtm
4 years, 3 months ago (2016-09-09 00:07:11 UTC) #7
iannucci
lgtm
4 years, 3 months ago (2016-09-09 00:08:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325513002/60001
4 years, 3 months ago (2016-09-09 00:16:58 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 00:20:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3454ae85da8913...

Powered by Google App Engine
This is Rietveld 408576698