Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: appengine/findit/crash/crash_pipeline.py

Issue 2325503002: Reorganizing detect_regression_range.py (Closed)
Patch Set: Addressing nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/detect_regression_range.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import copy 5 import copy
6 import json 6 import json
7 import logging 7 import logging
8 8
9 from google.appengine.api import app_identity 9 from google.appengine.api import app_identity
10 from google.appengine.ext import ndb 10 from google.appengine.ext import ndb
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 'signature_blacklist_markers', []): 172 'signature_blacklist_markers', []):
173 if blacklist_marker in signature: 173 if blacklist_marker in signature:
174 logging.info('%s signature is not supported. ' 174 logging.info('%s signature is not supported. '
175 'No analysis is scheduled for %s', blacklist_marker, 175 'No analysis is scheduled for %s', blacklist_marker,
176 repr(crash_identifiers)) 176 repr(crash_identifiers))
177 return False 177 return False
178 178
179 # TODO(katesonia): Remove the default value after adding validity check to 179 # TODO(katesonia): Remove the default value after adding validity check to
180 # config. 180 # config.
181 platform_rename = crash_config.fracas.get('platform_rename', {}) 181 platform_rename = crash_config.fracas.get('platform_rename', {})
182 platform = platform_rename.get(platform,platform) 182 platform = platform_rename.get(platform, platform)
183 183
184 if _NeedsNewAnalysis(crash_identifiers, chrome_version, signature, client_id, 184 if _NeedsNewAnalysis(crash_identifiers, chrome_version, signature, client_id,
185 platform, stack_trace, channel, historical_metadata): 185 platform, stack_trace, channel, historical_metadata):
186 analysis_pipeline = CrashWrapperPipeline(crash_identifiers) 186 analysis_pipeline = CrashWrapperPipeline(crash_identifiers)
187 # Attribute defined outside __init__ - pylint: disable=W0201 187 # Attribute defined outside __init__ - pylint: disable=W0201
188 analysis_pipeline.target = appengine_util.GetTargetNameForModule( 188 analysis_pipeline.target = appengine_util.GetTargetNameForModule(
189 constants.CRASH_BACKEND_FRACAS) 189 constants.CRASH_BACKEND_FRACAS)
190 analysis_pipeline.start(queue_name=queue_name) 190 analysis_pipeline.start(queue_name=queue_name)
191 logging.info('New analysis is scheduled for %s', repr(crash_identifiers)) 191 logging.info('New analysis is scheduled for %s', repr(crash_identifiers))
192 return True 192 return True
193 193
194 return False 194 return False
OLDNEW
« no previous file with comments | « no previous file | appengine/findit/crash/detect_regression_range.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698