Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(58)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/js/Promise-native-then-expected.txt
Issue
23254004
:
Implement ScriptPromise and ScriptFunction (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Control shouldn't reach the end of a non-void function
Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/js/Promise-native-then.html
LayoutTests/fast/js/Promise-native-then-expected.txt
Source/bindings/bindings.gypi
Source/bindings/v8/GarbageCollected.h
Source/bindings/v8/ScopedPersistent.h
Source/bindings/v8/ScriptFunction.h
Source/bindings/v8/ScriptPromise.h
Source/core/testing/Internals.h
Source/core/testing/Internals.cpp
Source/core/testing/Internals.idl
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/fast/js/Promise-native-then.html
('k') |
Source/bindings/bindings.gypi »
('j') |
Source/core/testing/Internals.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
CONSOLE MESSAGE: line 16: Got a new promise: [object Promise]
1 Test Promise.
2 Test Promise.
2
3
3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".
4 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".
4
5
5
PASS result is
"foo"
6
PASS result is
11
6 PASS successfullyParsed is true
7 PASS successfullyParsed is true
7
8
8 TEST COMPLETE
9 TEST COMPLETE
9
10
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/js/Promise-native-then.html
('k') |
Source/bindings/bindings.gypi »
('j') |
Source/core/testing/Internals.cpp »
('J')
Issue 23254004: Implement ScriptPromise and ScriptFunction (Closed)
Created 7 years, 4 months ago by abarth-chromium
Modified 6 years, 11 months ago
Reviewers: alecflett
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 1
This is Rietveld
408576698