Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 23253005: [Android] Small java changes for EMMA code coverage (Closed)

Created:
7 years, 4 months ago by gkanwar1
Modified:
7 years, 4 months ago
Reviewers:
joth
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, frankf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Small java changes for EMMA code coverage One piece of the overall java coverage change. See: https://codereview.chromium.org/20210002/ NOTRY=True BUG=255644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218559

Patch Set 1 #

Patch Set 2 : Replaces volatile fix with an assertion for null #

Total comments: 2

Patch Set 3 : Adds comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M android_webview/test/shell/AndroidManifest.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/testshell/java/AndroidManifest.xml View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gkanwar1
Joth -- These are the Java changes for the code coverage: * Fix for CleanupReferenceTest ...
7 years, 4 months ago (2013-08-20 18:31:19 UTC) #1
gkanwar1
On 2013/08/20 18:31:19, gkanwar1 wrote: > Joth -- These are the Java changes for the ...
7 years, 4 months ago (2013-08-20 18:39:31 UTC) #2
gkanwar1
Replaced the volatile fix with an assert as you suggested in the other CL. I ...
7 years, 4 months ago (2013-08-20 18:52:48 UTC) #3
joth
lgtm https://codereview.chromium.org/23253005/diff/6001/content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java File content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java (right): https://codereview.chromium.org/23253005/diff/6001/content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java#newcode61 content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java:61: assertTrue(instance == null); comment both these // Ensure ...
7 years, 4 months ago (2013-08-20 19:33:31 UTC) #4
gkanwar1
Thanks. Just waiting on trybots to run tests from PS 2, then I'll land this. ...
7 years, 4 months ago (2013-08-20 19:59:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23253005/15001
7 years, 4 months ago (2013-08-20 22:23:03 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 22:25:29 UTC) #7
Message was sent while issue was closed.
Change committed as 218559

Powered by Google App Engine
This is Rietveld 408576698