[Android] Small java changes for EMMA code coverage

[Android] Small java changes for EMMA code coverage

One piece of the overall java coverage change.
See: https://codereview.chromium.org/20210002/ 

NOTRY=True
BUG=255644
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218559

[gkanwar1, 2013-08-20 18:31:19]

Joth -- These are the Java changes for the code coverage:
* Fix for CleanupReferenceTest
* Allowing write access to SDCard for test shell packages.

I also looked into the AwContentsTest that you mentioned, and it looks like a
similar change is not needed there because the changes that allow GC are inside
a loop block, which shouldn't (if I'm not mistaken) be re-ordered with the GC
itself.

ptal, thanks!

[gkanwar1, 2013-08-20 18:39:31]

On 2013/08/20 18:31:19, gkanwar1 wrote:
> Joth -- These are the Java changes for the code coverage:
> * Fix for CleanupReferenceTest
> * Allowing write access to SDCard for test shell packages.
> 
> I also looked into the AwContentsTest that you mentioned, and it looks like a
> similar change is not needed there because the changes that allow GC are
inside
> a loop block, which shouldn't (if I'm not mistaken) be re-ordered with the GC
> itself.
> 
> ptal, thanks!

Just saw your comments in the overall CL. Playing with those changes now.

[gkanwar1, 2013-08-20 18:52:48]

Replaced the volatile fix with an assert as you suggested in the other CL. I
like this fix, since it's lighter and cleaner than the AtomicReference fix.

[joth, 2013-08-20 19:33:31]

lgtm

https://codereview.chromium.org/23253005/diff/6001/content/public/android/jav...
File
content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java
(right):

https://codereview.chromium.org/23253005/diff/6001/content/public/android/jav...
content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java:61:
assertTrue(instance == null);
comment both these

// Ensure compiler / instrumentation does not strip out the assignment.

[gkanwar1, 2013-08-20 19:59:46]

Thanks. Just waiting on trybots to run tests from PS 2, then I'll land this.

https://codereview.chromium.org/23253005/diff/6001/content/public/android/jav...
File
content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java
(right):

https://codereview.chromium.org/23253005/diff/6001/content/public/android/jav...
content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java:61:
assertTrue(instance == null);
On 2013/08/20 19:33:31, joth wrote:
> comment both these
> 
> // Ensure compiler / instrumentation does not strip out the assignment.

Done.

[commit-bot: I haz the power, 2013-08-20 22:23:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23253005/15001

[commit-bot: I haz the power, 2013-08-20 22:25:29]

Change committed as 218559