Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2325273002: Update test cases for FreeText annotations. (Closed)

Created:
4 years, 3 months ago by jaepark
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update test cases for FreeText annotations. There is a slight difference when FreeText annotations are drawn with FPDF_RenderPageBitmap_Retail and FPDF_FFLDraw. Previously, all annotations are drawn through FPDF_FFLDraw. However, since FreeText annotations should only be drawn through FPDF_RenderPageBitmap_Retail, the test cases with FreeText annotations is updated. Additionally, PDF annotation with NoView flag should not be drawn. This test case is also updated. BUG=pdfium:594 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/8485b3093524ddb7319e0381ab10c576e59d5091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M fx/FRC_3.5_part1/FRC_3.5_AuthEvent_EFOpen_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_CFM_AESV2__EncryptMetadata_F_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_CF_EFF_StdCF_Strf_Stmf_Identity_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_CF_Strf_stmf_StdCF_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_EncryptMetadata_None_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_V_4_CFM_V2__expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_V_5_CFM_AESV3_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_v_1_length_40_Filter_standard_expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_3.5_part1/FRC_3.5_v_2_length_128_AuthEvent_DocOpen__expected.pdf.0.png View Binary file 0 comments Download
M fx/FRC_8.4_part2/FRC_8.4.2_Annotation_Flags_F_NoView_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/combo_box_format_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/form_same_expected.pdf.0.png View Binary file 0 comments Download
M fx/form/form_same_expected.pdf.1.png View Binary file 0 comments Download
M fx/form/format_text_color_expected.pdf.0.png View Binary file 0 comments Download
M fx/js/action_on_focus_expected.pdf.0.png View Binary file 0 comments Download
M fx/js/app_launchurl_expected.pdf.0.png View Binary file 0 comments Download
M fx/js/submit_form_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/2/2_11_stamp3_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/2/2_8_stamp1_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/2/2_9_stamp2_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/new/stamp/new_stamp4_expected.pdf.0.png View Binary file 0 comments Download
M fx/mulobj/new/stamp/new_stamp5_expected.pdf.0.png View Binary file 0 comments Download
M fx/text/en_diy_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 5 (2 generated)
jaepark
4 years, 3 months ago (2016-09-09 22:16:33 UTC) #2
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-09 22:21:37 UTC) #3
jaepark
4 years, 3 months ago (2016-09-09 22:22:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8485b3093524ddb7319e0381ab10c576e59d5091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698