Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2325213002: Initialize unintialized field. (Closed)

Created:
4 years, 3 months ago by davidben
Modified:
4 years, 3 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, darin-cc_chromium.org, dmurph
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize unintialized field. I added something to ResourceResponseInfo in https://codereview.chromium.org/2272603003/ and forgot to initialize it in the constructor. BUG=645514 TBR=nasko@chromium.org Committed: https://crrev.com/ce9ba493ae688f8d41fc652ed1cbceafc532d17c Cr-Commit-Position: refs/heads/master@{#417655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/public/common/resource_response_info.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
davidben
(TBRing per dmurph.)
4 years, 3 months ago (2016-09-09 18:03:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325213002/1
4 years, 3 months ago (2016-09-09 18:03:34 UTC) #8
nasko
LGTM
4 years, 3 months ago (2016-09-09 18:07:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 19:04:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 19:05:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce9ba493ae688f8d41fc652ed1cbceafc532d17c
Cr-Commit-Position: refs/heads/master@{#417655}

Powered by Google App Engine
This is Rietveld 408576698