content/renderer/render_view_impl.h - Issue 23252006: Cleanup after https://codereview.chromium.org/18799006/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 23252006: Cleanup after https://codereview.chromium.org/18799006/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix for jam Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 8571234d5bd1266b17c5be9071b49d6f1ee7769f..b7fea6597ed4b9a0df758facd3642142025b9abd 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -448,16 +448,11 @@ class CONTENT_EXPORT RenderViewImpl

virtual WebKit::WebStorageNamespace* createSessionStorageNamespace();

virtual bool shouldReportDetailedMessageForSource(

const WebKit::WebString& source);

- // TODO(rdevlin.cronin): Remove this version once

- // https://codereview.chromium.org/18822004/ lands.

virtual void didAddMessageToConsole(

const WebKit::WebConsoleMessage& message,

const WebKit::WebString& source_name,

- unsigned source_line);

- virtual void didAddMessageToConsole(

- const WebKit::WebConsoleMessage& message,

- const WebKit::WebString& source_name,

- unsigned source_line, const WebKit::WebString& stack_trace);

+ unsigned source_line,

+ const WebKit::WebString& stack_trace);

virtual void printPage(WebKit::WebFrame* frame);

virtual WebKit::WebNotificationPresenter* notificationPresenter();

virtual bool enumerateChosenDirectory(

« no previous file with comments | « content/public/renderer/content_renderer_client.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »