Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2325193002: MD Settings/About: Implement update progress percentage (Closed)
Patch Set: fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index cdf419a16127abacf240781862a792db44cce77d..520e4acf59ac509ce89cf1a7ed3dcd433b14faca 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -166,7 +166,9 @@ Polymer({
this.i18n(settings.browserChannelToI18nId(this.targetChannel_)));
hcarmona 2016/09/09 21:51:52 Does changing the channel also need a progress per
Dan Beam 2016/09/10 00:56:02 Done. (thanks!)
}
</if>
- return this.i18n('aboutUpgradeUpdating');
+ assert(typeof this.currentUpdateStatusEvent_.progress == 'number');
+ return this.i18n('aboutUpgradeUpdating',
+ this.currentUpdateStatusEvent_.progress + '%');
default:
var message = this.currentUpdateStatusEvent_.message;
return message ?
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698