Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2325143002: Node.replaceChild with an empty DocumentFragment should not dispatch DOMSubtreeModified twice. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Node.replaceChild with an empty DocumentFragment should not dispatch DOMSubtreeModified twice. We should check the emptiness. The new behavior matches to Firefox and Edge. * LayoutTests/fast/loader/delete-inside-cancelTimer.html The replaceChild behavior change affects the output of the test. This CL doesn't update the result and removes the test entirely because - It's a crash test for CachedResource. [1] - Now the class is on Oilpan heap, and the test isn't helpful at all. [1] https://chromium.googlesource.com/chromium/src/+/5e8f72d1c3a42b5ab0c727f52c24009b36721255 BUG=645441 Committed: https://crrev.com/8f99074d5ad2b2ef95d3192b37884dc434e71ff3 Cr-Commit-Position: refs/heads/master@{#417871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -100 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/replaceChild-domsubtreemodified.html View 1 chunk +17 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/delete-inside-cancelTimer.html View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/delete-inside-cancelTimer-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
hayato@, would you review this please?
4 years, 3 months ago (2016-09-09 13:47:37 UTC) #4
hayato
lgtm
4 years, 3 months ago (2016-09-12 03:53:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325143002/1
4 years, 3 months ago (2016-09-12 04:08:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 05:41:22 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 05:43:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f99074d5ad2b2ef95d3192b37884dc434e71ff3
Cr-Commit-Position: refs/heads/master@{#417871}

Powered by Google App Engine
This is Rietveld 408576698