Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2325133002: [interpreter] Fix destroyed new.target register use. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix destroyed new.target register use. This fixes a corner-case where the bytecode was using the <new.target> register directly without going through the local variable. The value might be clobbered because the deoptimizer doesn't properly restore the value. The label will causes bytecode pipeline to be flushed and hence ensure {BytecodeRegisterOptimizer} doesn't reuse <new.target> anymore. R=rmcilroy@chromium.org TEST=mjsunit/regress/regress-crbug-645103 BUG=chromium:645103 Committed: https://crrev.com/0681deb9142f7845b2d28e062664a0e63c601b68 Cr-Commit-Position: refs/heads/master@{#39306}

Patch Set 1 #

Patch Set 2 : Recement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 1 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/NewTarget.golden View 1 2 chunks +4 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-645103.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-09 11:29:49 UTC) #1
rmcilroy
lgtm, thanks.
4 years, 3 months ago (2016-09-09 11:46:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325133002/20001
4 years, 3 months ago (2016-09-09 12:18:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 12:19:56 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 12:20:27 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0681deb9142f7845b2d28e062664a0e63c601b68
Cr-Commit-Position: refs/heads/master@{#39306}

Powered by Google App Engine
This is Rietveld 408576698