Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
23251006:
Opt *.corp.google.com into HSTS. (Closed)
|
Created:
7 years, 3 months ago by Chris Evans Modified:
7 years, 3 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionOpt *.corp.google.com into HSTS.
BUG=270911
R=mal@chromium.org, rsleevi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219811
Patch Set 1 #
Messages
Total messages: 9 (0 generated)
LGTM. Thanks for advanced warning :) On Aug 26, 2013 12:06 AM, <cevans@chromium.org> wrote: > Reviewers: Mark Larson, Ryan Sleevi, > > Description: > Opt *.corp.google.com into HSTS. > > BUG=270911 > > Please review this at https://codereview.chromium.**org/23251006/<https://codereview.chromium.org/2... > > SVN Base: svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src> > > Affected files: > M net/http/transport_security_**state_static.h > M net/http/transport_security_**state_static.json > M net/http/transport_security_**state_unittest.cc > > > Index: net/http/transport_security_**state_static.h > diff --git a/net/http/transport_security_**state_static.h > b/net/http/transport_security_**state_static.h > index f7ca89d1457fd06359fd6bcb56d339**83cba78625..** > 398e055c45642cfb033fbcd1598226**afb26dfa86 100644 > --- a/net/http/transport_security_**state_static.h > +++ b/net/http/transport_security_**state_static.h > @@ -382,6 +382,7 @@ static const char* const kCryptoCatAcceptableCerts[] = > { > static const struct HSTSPreload kPreloadedSTS[] = { > {25, true, "\013pinningtest\007appspot\**003com", false, kTestPins, > DOMAIN_APPSPOT_COM }, > {12, true, "\006google\003com", false, kGooglePins, DOMAIN_GOOGLE_COM }, > + {17, true, "\004corp\006google\003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > {19, true, "\006health\006google\003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > {21, true, "\010checkout\006google\**003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > {19, true, "\006chrome\006google\003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > Index: net/http/transport_security_**state_static.json > diff --git a/net/http/transport_security_**state_static.json > b/net/http/transport_security_**state_static.json > index f2ea764db5fe40adfd6f0e7b69621f**3d706eae01..** > 318113faf756cff4e779d00873ab6b**f13cf0c074 100644 > --- a/net/http/transport_security_**state_static.json > +++ b/net/http/transport_security_**state_static.json > @@ -159,6 +159,7 @@ > { "name": "google.com", "include_subdomains": true, "pins": "google" > }, > > // Now we force HTTPS for subtrees of google.com. > + { "name": "corp.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > { "name": "health.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > { "name": "checkout.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > { "name": "chrome.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > Index: net/http/transport_security_**state_unittest.cc > diff --git a/net/http/transport_security_**state_unittest.cc > b/net/http/transport_security_**state_unittest.cc > index 99d8c39f0425228d572afd3667fcc0**d4d95da7f8..** > 5b5dcc84799717119f45376591abd2**20380d1094 100644 > --- a/net/http/transport_security_**state_unittest.cc > +++ b/net/http/transport_security_**state_unittest.cc > @@ -258,6 +258,8 @@ TEST_F(**TransportSecurityStateTest, Preloaded) { > EXPECT_TRUE(ShouldRedirect("pl**us.google.com <http://plus.google.com> > ")); > EXPECT_TRUE(ShouldRedirect("gr**oups.google.com<http://groups.google.com> > ")); > EXPECT_TRUE(ShouldRedirect("ap**is.google.com <http://apis.google.com> > ")); > + EXPECT_TRUE(ShouldRedirect("bl**ah.corp.google.com<http://blah.corp.google.com> > ")); > + EXPECT_FALSE(ShouldRedirect("w**ww.google.com <http://www.google.com> > ")); > EXPECT_FALSE(ShouldRedirect("c**hart.apis.google.com<http://chart.apis.google.com> > ")); > EXPECT_TRUE(ShouldRedirect("ss**l.google-analytics.com<http://ssl.google-analytics.com> > ")); > EXPECT_TRUE(ShouldRedirect("gm**ail.com <http://gmail.com>")); > > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Palmer and I talked about this roughly a year ago, and we weren't sure if we wanted to land internal domains into the tree, or whether we should 'do it right' and somehow expose it via enterprise policy. There was also a concern about local (HTTP) instances on users' machines. I'm with you on the motivation, but I have a lot of concerns here for the fallout. I just want to make sure its been considered. Otherwise this change looks fine on a technical and I can stamp. On Aug 26, 2013 12:06 AM, <cevans@chromium.org> wrote: > Reviewers: Mark Larson, Ryan Sleevi, > > Description: > Opt *.corp.google.com into HSTS. > > BUG=270911 > > Please review this at https://codereview.chromium.**org/23251006/<https://codereview.chromium.org/2... > > SVN Base: svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src> > > Affected files: > M net/http/transport_security_**state_static.h > M net/http/transport_security_**state_static.json > M net/http/transport_security_**state_unittest.cc > > > Index: net/http/transport_security_**state_static.h > diff --git a/net/http/transport_security_**state_static.h > b/net/http/transport_security_**state_static.h > index f7ca89d1457fd06359fd6bcb56d339**83cba78625..** > 398e055c45642cfb033fbcd1598226**afb26dfa86 100644 > --- a/net/http/transport_security_**state_static.h > +++ b/net/http/transport_security_**state_static.h > @@ -382,6 +382,7 @@ static const char* const kCryptoCatAcceptableCerts[] = > { > static const struct HSTSPreload kPreloadedSTS[] = { > {25, true, "\013pinningtest\007appspot\**003com", false, kTestPins, > DOMAIN_APPSPOT_COM }, > {12, true, "\006google\003com", false, kGooglePins, DOMAIN_GOOGLE_COM }, > + {17, true, "\004corp\006google\003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > {19, true, "\006health\006google\003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > {21, true, "\010checkout\006google\**003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > {19, true, "\006chrome\006google\003com", true, kGooglePins, > DOMAIN_GOOGLE_COM }, > Index: net/http/transport_security_**state_static.json > diff --git a/net/http/transport_security_**state_static.json > b/net/http/transport_security_**state_static.json > index f2ea764db5fe40adfd6f0e7b69621f**3d706eae01..** > 318113faf756cff4e779d00873ab6b**f13cf0c074 100644 > --- a/net/http/transport_security_**state_static.json > +++ b/net/http/transport_security_**state_static.json > @@ -159,6 +159,7 @@ > { "name": "google.com", "include_subdomains": true, "pins": "google" > }, > > // Now we force HTTPS for subtrees of google.com. > + { "name": "corp.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > { "name": "health.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > { "name": "checkout.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > { "name": "chrome.google.com", "include_subdomains": true, "mode": > "force-https", "pins": "google" }, > Index: net/http/transport_security_**state_unittest.cc > diff --git a/net/http/transport_security_**state_unittest.cc > b/net/http/transport_security_**state_unittest.cc > index 99d8c39f0425228d572afd3667fcc0**d4d95da7f8..** > 5b5dcc84799717119f45376591abd2**20380d1094 100644 > --- a/net/http/transport_security_**state_unittest.cc > +++ b/net/http/transport_security_**state_unittest.cc > @@ -258,6 +258,8 @@ TEST_F(**TransportSecurityStateTest, Preloaded) { > EXPECT_TRUE(ShouldRedirect("pl**us.google.com <http://plus.google.com> > ")); > EXPECT_TRUE(ShouldRedirect("gr**oups.google.com<http://groups.google.com> > ")); > EXPECT_TRUE(ShouldRedirect("ap**is.google.com <http://apis.google.com> > ")); > + EXPECT_TRUE(ShouldRedirect("bl**ah.corp.google.com<http://blah.corp.google.com> > ")); > + EXPECT_FALSE(ShouldRedirect("w**ww.google.com <http://www.google.com> > ")); > EXPECT_FALSE(ShouldRedirect("c**hart.apis.google.com<http://chart.apis.google.com> > ")); > EXPECT_TRUE(ShouldRedirect("ss**l.google-analytics.com<http://ssl.google-analytics.com> > ")); > EXPECT_TRUE(ShouldRedirect("gm**ail.com <http://gmail.com>")); > > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
I believe that Uberproxy has been setting HSTS for some corp.gooogle.com hosts, but this would mean that one can no longer access http://mymachine.foo.corp.google.com. Seems like it would piss some people off, but I guess we could try and see. On Mon, Aug 26, 2013 at 12:51 PM, Ryan Sleevi <rsleevi@chromium.org> wrote: > Palmer and I talked about this roughly a year ago, and we weren't sure if we > wanted to land internal domains into the tree, or whether we should 'do it > right' and somehow expose it via enterprise policy. > > There was also a concern about local (HTTP) instances on users' machines. > > I'm with you on the motivation, but I have a lot of concerns here for the > fallout. I just want to make sure its been considered. Otherwise this change > looks fine on a technical and I can stamp. > > On Aug 26, 2013 12:06 AM, <cevans@chromium.org> wrote: >> >> Reviewers: Mark Larson, Ryan Sleevi, >> >> Description: >> Opt *.corp.google.com into HSTS. >> >> BUG=270911 >> >> Please review this at https://codereview.chromium.org/23251006/ >> >> SVN Base: svn://svn.chromium.org/chrome/trunk/src >> >> Affected files: >> M net/http/transport_security_state_static.h >> M net/http/transport_security_state_static.json >> M net/http/transport_security_state_unittest.cc >> >> >> Index: net/http/transport_security_state_static.h >> diff --git a/net/http/transport_security_state_static.h >> b/net/http/transport_security_state_static.h >> index >> f7ca89d1457fd06359fd6bcb56d33983cba78625..398e055c45642cfb033fbcd1598226afb26dfa86 >> 100644 >> --- a/net/http/transport_security_state_static.h >> +++ b/net/http/transport_security_state_static.h >> @@ -382,6 +382,7 @@ static const char* const kCryptoCatAcceptableCerts[] = >> { >> static const struct HSTSPreload kPreloadedSTS[] = { >> {25, true, "\013pinningtest\007appspot\003com", false, kTestPins, >> DOMAIN_APPSPOT_COM }, >> {12, true, "\006google\003com", false, kGooglePins, DOMAIN_GOOGLE_COM >> }, >> + {17, true, "\004corp\006google\003com", true, kGooglePins, >> DOMAIN_GOOGLE_COM }, >> {19, true, "\006health\006google\003com", true, kGooglePins, >> DOMAIN_GOOGLE_COM }, >> {21, true, "\010checkout\006google\003com", true, kGooglePins, >> DOMAIN_GOOGLE_COM }, >> {19, true, "\006chrome\006google\003com", true, kGooglePins, >> DOMAIN_GOOGLE_COM }, >> Index: net/http/transport_security_state_static.json >> diff --git a/net/http/transport_security_state_static.json >> b/net/http/transport_security_state_static.json >> index >> f2ea764db5fe40adfd6f0e7b69621f3d706eae01..318113faf756cff4e779d00873ab6bf13cf0c074 >> 100644 >> --- a/net/http/transport_security_state_static.json >> +++ b/net/http/transport_security_state_static.json >> @@ -159,6 +159,7 @@ >> { "name": "google.com", "include_subdomains": true, "pins": "google" >> }, >> >> // Now we force HTTPS for subtrees of google.com. >> + { "name": "corp.google.com", "include_subdomains": true, "mode": >> "force-https", "pins": "google" }, >> { "name": "health.google.com", "include_subdomains": true, "mode": >> "force-https", "pins": "google" }, >> { "name": "checkout.google.com", "include_subdomains": true, "mode": >> "force-https", "pins": "google" }, >> { "name": "chrome.google.com", "include_subdomains": true, "mode": >> "force-https", "pins": "google" }, >> Index: net/http/transport_security_state_unittest.cc >> diff --git a/net/http/transport_security_state_unittest.cc >> b/net/http/transport_security_state_unittest.cc >> index >> 99d8c39f0425228d572afd3667fcc0d4d95da7f8..5b5dcc84799717119f45376591abd220380d1094 >> 100644 >> --- a/net/http/transport_security_state_unittest.cc >> +++ b/net/http/transport_security_state_unittest.cc >> @@ -258,6 +258,8 @@ TEST_F(TransportSecurityStateTest, Preloaded) { >> EXPECT_TRUE(ShouldRedirect("plus.google.com")); >> EXPECT_TRUE(ShouldRedirect("groups.google.com")); >> EXPECT_TRUE(ShouldRedirect("apis.google.com")); >> + EXPECT_TRUE(ShouldRedirect("blah.corp.google.com")); >> + EXPECT_FALSE(ShouldRedirect("www.google.com")); >> EXPECT_FALSE(ShouldRedirect("chart.apis.google.com")); >> EXPECT_TRUE(ShouldRedirect("ssl.google-analytics.com")); >> EXPECT_TRUE(ShouldRedirect("gmail.com")); >> >> > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2013/08/26 16:54:33, agl wrote: > I believe that Uberproxy has been setting HSTS for some > http://corp.gooogle.com hosts, but this would mean that one can no longer > access http://mymachine.foo.corp.google.com. Seems like it would piss > some people off, but I guess we could try and see. Yeah, Mark was a specific fan of "try it and see", once M30 branched (it has). > > On Mon, Aug 26, 2013 at 12:51 PM, Ryan Sleevi <mailto:rsleevi@chromium.org> wrote: > > Palmer and I talked about this roughly a year ago, and we weren't sure if we > > wanted to land internal domains into the tree, or whether we should 'do it > > right' and somehow expose it via enterprise policy. > > > > There was also a concern about local (HTTP) instances on users' machines. > > > > I'm with you on the motivation, but I have a lot of concerns here for the > > fallout. I just want to make sure its been considered. Otherwise this change > > looks fine on a technical and I can stamp. > > > > On Aug 26, 2013 12:06 AM, <mailto:cevans@chromium.org> wrote: > >> > >> Reviewers: Mark Larson, Ryan Sleevi, > >> > >> Description: > >> Opt *.corp.google.com into HSTS. > >> > >> BUG=270911 > >> > >> Please review this at https://codereview.chromium.org/23251006/ > >> > >> SVN Base: svn://svn.chromium.org/chrome/trunk/src > >> > >> Affected files: > >> M net/http/transport_security_state_static.h > >> M net/http/transport_security_state_static.json > >> M net/http/transport_security_state_unittest.cc > >> > >> > >> Index: net/http/transport_security_state_static.h > >> diff --git a/net/http/transport_security_state_static.h > >> b/net/http/transport_security_state_static.h > >> index > >> > f7ca89d1457fd06359fd6bcb56d33983cba78625..398e055c45642cfb033fbcd1598226afb26dfa86 > >> 100644 > >> --- a/net/http/transport_security_state_static.h > >> +++ b/net/http/transport_security_state_static.h > >> @@ -382,6 +382,7 @@ static const char* const kCryptoCatAcceptableCerts[] = > >> { > >> static const struct HSTSPreload kPreloadedSTS[] = { > >> {25, true, "\013pinningtest\007appspot\003com", false, kTestPins, > >> DOMAIN_APPSPOT_COM }, > >> {12, true, "\006google\003com", false, kGooglePins, DOMAIN_GOOGLE_COM > >> }, > >> + {17, true, "\004corp\006google\003com", true, kGooglePins, > >> DOMAIN_GOOGLE_COM }, > >> {19, true, "\006health\006google\003com", true, kGooglePins, > >> DOMAIN_GOOGLE_COM }, > >> {21, true, "\010checkout\006google\003com", true, kGooglePins, > >> DOMAIN_GOOGLE_COM }, > >> {19, true, "\006chrome\006google\003com", true, kGooglePins, > >> DOMAIN_GOOGLE_COM }, > >> Index: net/http/transport_security_state_static.json > >> diff --git a/net/http/transport_security_state_static.json > >> b/net/http/transport_security_state_static.json > >> index > >> > f2ea764db5fe40adfd6f0e7b69621f3d706eae01..318113faf756cff4e779d00873ab6bf13cf0c074 > >> 100644 > >> --- a/net/http/transport_security_state_static.json > >> +++ b/net/http/transport_security_state_static.json > >> @@ -159,6 +159,7 @@ > >> { "name": "google.com", "include_subdomains": true, "pins": "google" > >> }, > >> > >> // Now we force HTTPS for subtrees of http://google.com. > >> + { "name": "corp.google.com", "include_subdomains": true, "mode": > >> "force-https", "pins": "google" }, > >> { "name": "health.google.com", "include_subdomains": true, "mode": > >> "force-https", "pins": "google" }, > >> { "name": "checkout.google.com", "include_subdomains": true, "mode": > >> "force-https", "pins": "google" }, > >> { "name": "chrome.google.com", "include_subdomains": true, "mode": > >> "force-https", "pins": "google" }, > >> Index: net/http/transport_security_state_unittest.cc > >> diff --git a/net/http/transport_security_state_unittest.cc > >> b/net/http/transport_security_state_unittest.cc > >> index > >> > 99d8c39f0425228d572afd3667fcc0d4d95da7f8..5b5dcc84799717119f45376591abd220380d1094 > >> 100644 > >> --- a/net/http/transport_security_state_unittest.cc > >> +++ b/net/http/transport_security_state_unittest.cc > >> @@ -258,6 +258,8 @@ TEST_F(TransportSecurityStateTest, Preloaded) { > >> EXPECT_TRUE(ShouldRedirect("plus.google.com")); > >> EXPECT_TRUE(ShouldRedirect("groups.google.com")); > >> EXPECT_TRUE(ShouldRedirect("apis.google.com")); > >> + EXPECT_TRUE(ShouldRedirect("blah.corp.google.com")); > >> + EXPECT_FALSE(ShouldRedirect("www.google.com")); > >> EXPECT_FALSE(ShouldRedirect("chart.apis.google.com")); > >> EXPECT_TRUE(ShouldRedirect("ssl.google-analytics.com")); > >> EXPECT_TRUE(ShouldRedirect("gmail.com")); > >> > >> > > > > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org.
In that case, LGTM. On Aug 26, 2013 11:32 AM, <cevans@chromium.org> wrote: > On 2013/08/26 16:54:33, agl wrote: > >> I believe that Uberproxy has been setting HSTS for some >> http://corp.gooogle.com hosts, but this would mean that one can no longer >> access http://mymachine.foo.corp.**google.com<http://mymachine.foo.corp.google.com>. >> Seems like it would piss >> some people off, but I guess we could try and see. >> > > Yeah, Mark was a specific fan of "try it and see", once M30 branched (it > has). > > > On Mon, Aug 26, 2013 at 12:51 PM, Ryan Sleevi <mailto: >> rsleevi@chromium.org> >> > wrote: > >> > Palmer and I talked about this roughly a year ago, and we weren't sure >> if we >> > wanted to land internal domains into the tree, or whether we should 'do >> it >> > right' and somehow expose it via enterprise policy. >> > >> > There was also a concern about local (HTTP) instances on users' >> machines. >> > >> > I'm with you on the motivation, but I have a lot of concerns here for >> the >> > fallout. I just want to make sure its been considered. Otherwise this >> change >> > looks fine on a technical and I can stamp. >> > >> > On Aug 26, 2013 12:06 AM, <mailto:cevans@chromium.org> wrote: >> >> >> >> Reviewers: Mark Larson, Ryan Sleevi, >> >> >> >> Description: >> >> Opt *.corp.google.com into HSTS. >> >> >> >> BUG=270911 >> >> >> >> Please review this at https://codereview.chromium.**org/23251006/<https://codereview.chromium.org/2... >> >> >> >> SVN Base: svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src> >> >> >> >> Affected files: >> >> M net/http/transport_security_**state_static.h >> >> M net/http/transport_security_**state_static.json >> >> M net/http/transport_security_**state_unittest.cc >> >> >> >> >> >> Index: net/http/transport_security_**state_static.h >> >> diff --git a/net/http/transport_security_**state_static.h >> >> b/net/http/transport_security_**state_static.h >> >> index >> >> >> > > f7ca89d1457fd06359fd6bcb56d339**83cba78625..** > 398e055c45642cfb033fbcd1598226**afb26dfa86 > >> >> 100644 >> >> --- a/net/http/transport_security_**state_static.h >> >> +++ b/net/http/transport_security_**state_static.h >> >> @@ -382,6 +382,7 @@ static const char* const >> kCryptoCatAcceptableCerts[] = >> >> { >> >> static const struct HSTSPreload kPreloadedSTS[] = { >> >> {25, true, "\013pinningtest\007appspot\**003com", false, kTestPins, >> >> DOMAIN_APPSPOT_COM }, >> >> {12, true, "\006google\003com", false, kGooglePins, >> DOMAIN_GOOGLE_COM >> >> }, >> >> + {17, true, "\004corp\006google\003com", true, kGooglePins, >> >> DOMAIN_GOOGLE_COM }, >> >> {19, true, "\006health\006google\003com", true, kGooglePins, >> >> DOMAIN_GOOGLE_COM }, >> >> {21, true, "\010checkout\006google\**003com", true, kGooglePins, >> >> DOMAIN_GOOGLE_COM }, >> >> {19, true, "\006chrome\006google\003com", true, kGooglePins, >> >> DOMAIN_GOOGLE_COM }, >> >> Index: net/http/transport_security_**state_static.json >> >> diff --git a/net/http/transport_security_**state_static.json >> >> b/net/http/transport_security_**state_static.json >> >> index >> >> >> > > f2ea764db5fe40adfd6f0e7b69621f**3d706eae01..** > 318113faf756cff4e779d00873ab6b**f13cf0c074 > >> >> 100644 >> >> --- a/net/http/transport_security_**state_static.json >> >> +++ b/net/http/transport_security_**state_static.json >> >> @@ -159,6 +159,7 @@ >> >> { "name": "google.com", "include_subdomains": true, "pins": >> "google" >> >> }, >> >> >> >> // Now we force HTTPS for subtrees of http://google.com. >> >> + { "name": "corp.google.com", "include_subdomains": true, "mode": >> >> "force-https", "pins": "google" }, >> >> { "name": "health.google.com", "include_subdomains": true, >> "mode": >> >> "force-https", "pins": "google" }, >> >> { "name": "checkout.google.com", "include_subdomains": true, >> "mode": >> >> "force-https", "pins": "google" }, >> >> { "name": "chrome.google.com", "include_subdomains": true, >> "mode": >> >> "force-https", "pins": "google" }, >> >> Index: net/http/transport_security_**state_unittest.cc >> >> diff --git a/net/http/transport_security_**state_unittest.cc >> >> b/net/http/transport_security_**state_unittest.cc >> >> index >> >> >> > > 99d8c39f0425228d572afd3667fcc0**d4d95da7f8..** > 5b5dcc84799717119f45376591abd2**20380d1094 > >> >> 100644 >> >> --- a/net/http/transport_security_**state_unittest.cc >> >> +++ b/net/http/transport_security_**state_unittest.cc >> >> @@ -258,6 +258,8 @@ TEST_F(**TransportSecurityStateTest, Preloaded) { >> >> EXPECT_TRUE(ShouldRedirect("pl**us.google.com<http://plus.google.com> >> ")); >> >> EXPECT_TRUE(ShouldRedirect("gr**oups.google.com<http://groups.google.com> >> ")); >> >> EXPECT_TRUE(ShouldRedirect("ap**is.google.com<http://apis.google.com> >> ")); >> >> + EXPECT_TRUE(ShouldRedirect("bl**ah.corp.google.com<http://blah.corp.google.com> >> ")); >> >> + EXPECT_FALSE(ShouldRedirect("w**ww.google.com<http://www.google.com> >> ")); >> >> EXPECT_FALSE(ShouldRedirect("c**hart.apis.google.com<http://chart.apis.google.com> >> ")); >> >> EXPECT_TRUE(ShouldRedirect("ss**l.google-analytics.com<http://ssl.google-analytics.com> >> ")); >> >> EXPECT_TRUE(ShouldRedirect("gm**ail.com <http://gmail.com>")); >> >> >> >> >> > >> > > To unsubscribe from this group and stop receiving emails from it, send an >> > email > >> to mailto:chromium-reviews+**unsubscribe@chromium.org<chromium-reviews%2Bunsubscribe@chromium.org> >> . >> > > > > https://codereview.chromium.**org/23251006/<https://codereview.chromium.org/2... > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/23251006/1
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
Message was sent while issue was closed.
Committed patchset #1 manually as r219811 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
