Record call counts also for megamorphic calls.

Record call counts also for megamorphic calls.

To make better inlining decisions, it's good to have call counts for poly/mega-morphic cases. This CL makes it work for calls, and another will follow to better unify the code between constructor calls and normal calls (and thence, to record megamorphic call counts there as well).

BUG=

Committed: https://crrev.com/2ab3fcf42f0cf04896b26bf23bc3809d8835fd39
Cr-Commit-Position: refs/heads/master@{#39377}

[mvstanton, 2016-09-13 08:42:08]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 08:42:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-09-13 08:52:35]

Description was changed from

==========
Record call counts also for megamorphic calls.

BUG=
==========

to

==========
Record call counts also for megamorphic calls.

To make better inlining decisions, it's good to have call counts for
poly/mega-morphic cases. This CL makes it work for calls, and another will
follow to better unify the code between constructor calls and normal calls (and
thence, to record megamorphic call counts there as well).

BUG=
==========

[mvstanton, 2016-09-13 08:52:35]

mvstanton@chromium.org changed reviewers:
+ benedikt.meurer@googlemail.com, mythria@chromium.org

[mvstanton, 2016-09-13 08:52:35]

mvstanton@chromium.org changed required reviewers:
+ benedikt.meurer@googlemail.com, mythria@chromium.org

[mvstanton, 2016-09-13 08:53:24]

Hi Benedikt, hi Mythri,

Mythri, could you examine the interpreter assembler changes? Benedikt, have a
look over the rest?

Thanks!
--Mike

[commit-bot: I haz the power, 2016-09-13 08:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 08:59:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[mvstanton, 2016-09-13 09:20:57]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 09:20:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-13 09:53:38]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org
- benedikt.meurer@googlemail.com

[Benedikt Meurer, 2016-09-13 09:53:38]

bmeurer@chromium.org changed required reviewers:
+ bmeurer@chromium.org
- benedikt.meurer@googlemail.com

[commit-bot: I haz the power, 2016-09-13 10:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 10:00:13]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-09-13 10:05:00]

Nice, lgtm on interpreter-assembler.

[mvstanton, 2016-09-13 10:13:47]

mvstanton@chromium.org changed required reviewers:
- bmeurer@chromium.org, mythria@chromium.org

[mvstanton, 2016-09-13 10:14:10]

Resending to correct review accounts :p

[Benedikt Meurer, 2016-09-13 10:34:58]

LGTM with nit.

https://codereview.chromium.org/2325083003/diff/60001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2325083003/diff/60001/src/type-feedback-vecto...
src/type-feedback-vector.cc:258: array->set(index + j, kind ==
FeedbackVectorSlotKind::CALL_IC
Nit: Hoist the value selection out of the loop.

[mvstanton, 2016-09-13 10:38:44]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-09-13 10:38:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/2325083003/#ps80001
(title: "Code comments.")

[commit-bot: I haz the power, 2016-09-13 10:38:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 11:03:48]

Description was changed from

==========
Record call counts also for megamorphic calls.

To make better inlining decisions, it's good to have call counts for
poly/mega-morphic cases. This CL makes it work for calls, and another will
follow to better unify the code between constructor calls and normal calls (and
thence, to record megamorphic call counts there as well).

BUG=
==========

to

==========
Record call counts also for megamorphic calls.

To make better inlining decisions, it's good to have call counts for
poly/mega-morphic cases. This CL makes it work for calls, and another will
follow to better unify the code between constructor calls and normal calls (and
thence, to record megamorphic call counts there as well).

BUG=
==========

[commit-bot: I haz the power, 2016-09-13 11:03:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-13 11:04:31]

Description was changed from

==========
Record call counts also for megamorphic calls.

To make better inlining decisions, it's good to have call counts for
poly/mega-morphic cases. This CL makes it work for calls, and another will
follow to better unify the code between constructor calls and normal calls (and
thence, to record megamorphic call counts there as well).

BUG=
==========

to

==========
Record call counts also for megamorphic calls.

To make better inlining decisions, it's good to have call counts for
poly/mega-morphic cases. This CL makes it work for calls, and another will
follow to better unify the code between constructor calls and normal calls (and
thence, to record megamorphic call counts there as well).

BUG=

Committed: https://crrev.com/2ab3fcf42f0cf04896b26bf23bc3809d8835fd39
Cr-Commit-Position: refs/heads/master@{#39377}
==========

[commit-bot: I haz the power, 2016-09-13 11:04:32]

Patchset 5 (id:??) landed as
https://crrev.com/2ab3fcf42f0cf04896b26bf23bc3809d8835fd39
Cr-Commit-Position: refs/heads/master@{#39377}