Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2325073002: [LayoutNG] Handle border and padding when sizing a block and when placing its children. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Handle border and padding when sizing a block and when placing its children. BUG=635619 Committed: https://crrev.com/539b00c243870d602bd89bbcdcf425d65553c1f5 Cr-Commit-Position: refs/heads/master@{#417827}

Patch Set 1 #

Patch Set 2 : Add unit test. #

Total comments: 1

Patch Set 3 : Use modern CSS terms, rather than old XSL terms, for box sides #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 1 chunk +74 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 2 2 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
mstensho (USE GERRIT)
Should I add some tests, or what's the policy here?
4 years, 3 months ago (2016-09-09 08:54:05 UTC) #2
eae
On 2016/09/09 08:54:05, mstensho wrote: > Should I add some tests, or what's the policy ...
4 years, 3 months ago (2016-09-09 10:43:34 UTC) #3
mstensho (USE GERRIT)
On 2016/09/09 10:43:34, eae wrote: > On 2016/09/09 08:54:05, mstensho wrote: > > Should I ...
4 years, 3 months ago (2016-09-09 12:19:13 UTC) #4
eae
Very nice LGTM
4 years, 3 months ago (2016-09-09 12:20:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325073002/20001
4 years, 3 months ago (2016-09-09 16:21:21 UTC) #7
ikilpatrick
lgtm \o/, nit can be fixed later just wanted to point it out. :) https://codereview.chromium.org/2325073002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc ...
4 years, 3 months ago (2016-09-09 16:33:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/28135)
4 years, 3 months ago (2016-09-09 17:28:44 UTC) #11
mstensho (USE GERRIT)
On 2016/09/09 16:33:06, ikilpatrick wrote: > lgtm \o/, nit can be fixed later just wanted ...
4 years, 3 months ago (2016-09-10 06:42:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325073002/40001
4 years, 3 months ago (2016-09-10 06:42:46 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-10 09:06:30 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 09:10:01 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/539b00c243870d602bd89bbcdcf425d65553c1f5
Cr-Commit-Position: refs/heads/master@{#417827}

Powered by Google App Engine
This is Rietveld 408576698