[LayoutNG] Handle border and padding when sizing a block and when placing its children.

[LayoutNG] Handle border and padding when sizing a block and when placing its children.

BUG=635619
Committed: https://crrev.com/539b00c243870d602bd89bbcdcf425d65553c1f5
Cr-Commit-Position: refs/heads/master@{#417827}

[mstensho (USE GERRIT), 2016-09-09 08:54:04]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[mstensho (USE GERRIT), 2016-09-09 08:54:05]

Should I add some tests, or what's the policy here?

[eae, 2016-09-09 10:43:34]

On 2016/09/09 08:54:05, mstensho wrote:
> Should I add some tests, or what's the policy here?

Yes please, unit tests for everything is our policy at the moment.

[mstensho (USE GERRIT), 2016-09-09 12:19:13]

On 2016/09/09 10:43:34, eae wrote:
> On 2016/09/09 08:54:05, mstensho wrote:
> > Should I add some tests, or what's the policy here?
> 
> Yes please, unit tests for everything is our policy at the moment.

Done.

[eae, 2016-09-09 12:20:35]

Very nice

LGTM

[eae, 2016-09-09 16:20:47]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-09-09 16:21:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-09-09 16:33:05]

ikilpatrick@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[ikilpatrick, 2016-09-09 16:33:06]

lgtm \o/, nit can be fixed later just wanted to point it out. :)

https://codereview.chromium.org/2325073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2325073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:121: LayoutUnit
computeBorderAndPaddingBefore(
small nit; trying to be consistent with css and only use the terminology in
writing modes spec.

i.e. s/Before/BlockStart , Start/InlineStart, etc. :)

[commit-bot: I haz the power, 2016-09-09 17:28:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 17:28:44]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mstensho (USE GERRIT), 2016-09-10 06:42:27]

On 2016/09/09 16:33:06, ikilpatrick wrote:
> lgtm \o/, nit can be fixed later just wanted to point it out. :)
> 
>
https://codereview.chromium.org/2325073002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):
> 
>
https://codereview.chromium.org/2325073002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:121: LayoutUnit
> computeBorderAndPaddingBefore(
> small nit; trying to be consistent with css and only use the terminology in
> writing modes spec.
> 
> i.e. s/Before/BlockStart , Start/InlineStart, etc. :)

Oh, pardon my XSL! :)

Since this CL failed to land, for no sensible reason, I went ahead and fixed it
here.

Done.

[mstensho (USE GERRIT), 2016-09-10 06:42:38]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-09-10 06:42:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2325073002/#ps40001
(title: "Use modern CSS terms, rather than old XSL terms, for box sides")

[commit-bot: I haz the power, 2016-09-10 06:42:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 09:06:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-10 09:10:00]

Description was changed from

==========
[LayoutNG] Handle border and padding when sizing a block and when placing its
children.

BUG=635619
==========

to

==========
[LayoutNG] Handle border and padding when sizing a block and when placing its
children.

BUG=635619

Committed: https://crrev.com/539b00c243870d602bd89bbcdcf425d65553c1f5
Cr-Commit-Position: refs/heads/master@{#417827}
==========

[commit-bot: I haz the power, 2016-09-10 09:10:01]

Patchset 3 (id:??) landed as
https://crrev.com/539b00c243870d602bd89bbcdcf425d65553c1f5
Cr-Commit-Position: refs/heads/master@{#417827}