Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2325053002: Revert of Stop copying script contents for each RenderFrames. (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, catmullings
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Stop copying script contents for each RenderFrames. (patchset #4 id:60001 of https://codereview.chromium.org/2278003002/ ) Reason for revert: Crashes renderer while destroying UserScriptSet via ChromeExtensionsRendererClient LazyInstance... Original issue's description: > Stop copying script contents for each RenderFrames. > > Instead, after unpickling the script content, put them in a WebString > on its first use (GetJsSources) in a frame. Reuse them for subsequent > frames. > > The cleanup is done when UserScriptSet releases its shared memory > connection. > > A completely naive test shows that on WSJ site, with ABPlus extension > installed, this reduced (24025 * 11 + 14785 * 10) = 412125 char copies! > > BUG=622464 > Test=No visible change is expected. > > Committed: https://crrev.com/0f702e9e3ccd2f408b198d2b2255d363da0310b9 > Cr-Commit-Position: refs/heads/master@{#417018} TBR=rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622464, 645357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -76 lines) Patch
M extensions/renderer/user_script_injector.h View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/renderer/user_script_injector.cc View 4 chunks +38 lines, -12 lines 0 comments Download
M extensions/renderer/user_script_set.h View 4 chunks +0 lines, -11 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 3 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lazyboy
Created Revert of Stop copying script contents for each RenderFrames.
4 years, 3 months ago (2016-09-09 07:55:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325053002/1
4 years, 3 months ago (2016-09-09 07:55:53 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 07:58:12 UTC) #6
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698