Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2325013004: [stubs] Port LoadScriptContextFieldStub and StoreScriptContextFieldStub to TurboFan. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Port LoadScriptContextFieldStub and StoreScriptContextFieldStub to TurboFan. BUG=v8:5269 Committed: https://crrev.com/6b000846a8372235c0a527cb39a28d13be857c4b Cr-Commit-Position: refs/heads/master@{#39376}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -69 lines) Patch
M src/code-stub-assembler.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 4 chunks +23 lines, -5 lines 0 comments Download
M src/code-stubs.h View 1 6 chunks +17 lines, -19 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (19 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-12 08:34:52 UTC) #8
mvstanton
lgtm
4 years, 3 months ago (2016-09-13 08:49:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325013004/40001
4 years, 3 months ago (2016-09-13 09:09:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23885)
4 years, 3 months ago (2016-09-13 09:12:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325013004/60001
4 years, 3 months ago (2016-09-13 09:20:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23891)
4 years, 3 months ago (2016-09-13 09:27:49 UTC) #22
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-13 09:36:20 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325013004/60001
4 years, 3 months ago (2016-09-13 09:37:18 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 3 months ago (2016-09-13 09:47:03 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 09:47:38 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b000846a8372235c0a527cb39a28d13be857c4b
Cr-Commit-Position: refs/heads/master@{#39376}

Powered by Google App Engine
This is Rietveld 408576698