Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2325013003: [stubs] Port StoreFieldStub to TurboFan. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Port StoreFieldStub to TurboFan. BUG=v8:5269 Committed: https://crrev.com/93fc4fea7b9de36d682c2610d5c9a721c982a14a Cr-Commit-Position: refs/heads/master@{#39350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -35 lines) Patch
M src/code-stub-assembler.h View 2 chunks +11 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 3 chunks +80 lines, -5 lines 0 comments Download
M src/code-stubs.h View 3 chunks +17 lines, -16 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-12 08:10:59 UTC) #10
mvstanton
Looks good! LGTM.
4 years, 3 months ago (2016-09-12 08:28:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325013003/20001
4 years, 3 months ago (2016-09-12 11:49:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-12 12:18:31 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 12:19:27 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93fc4fea7b9de36d682c2610d5c9a721c982a14a
Cr-Commit-Position: refs/heads/master@{#39350}

Powered by Google App Engine
This is Rietveld 408576698