chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java - Issue 2324983002: [Android] Wire up manual crash uploads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

Issue 2324983002: [Android] Wire up manual crash uploads. (Closed)

Patch Set: Remove another #if wrapper Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java ('k') | chrome/browser/BUILD.gn » ('j') | chrome/browser/crash_upload_list/crash_upload_list_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

index 4fe24c386284563e58bfcf94d3660973a80ca7fc..b2a506969ddc7c25684377580a88cf9b7589d6ee 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

@@ -389,7 +389,7 @@ public class MinidumpUploadServiceTest extends CrashTestCase {

// Run test.

MinidumpUploadService service = new TestMinidumpUploadService(context);

- service.tryUploadCrashDumpWithLocalId("f297dbcba7a2d0bb");

+ service.tryUploadCrashDumpWithLocalIdImpl("f297dbcba7a2d0bb");

// Verify.

assertTrue("Should have called startService(...)", context.isFlagSet(startServiceFlag));

@@ -421,7 +421,7 @@ public class MinidumpUploadServiceTest extends CrashTestCase {

// Run test.

MinidumpUploadService service = new TestMinidumpUploadService(context);

- service.tryUploadCrashDumpWithLocalId("f297dbcba7a2d0bb");

+ service.tryUploadCrashDumpWithLocalIdImpl("f297dbcba7a2d0bb");

// Verify.

assertTrue("Should have called startService(...)", context.isFlagSet(startServiceFlag));

@@ -444,7 +444,7 @@ public class MinidumpUploadServiceTest extends CrashTestCase {

// Run test.

MinidumpUploadService service = new TestMinidumpUploadService(context);

- service.tryUploadCrashDumpWithLocalId("f297dbcba7a2d0bb");

+ service.tryUploadCrashDumpWithLocalIdImpl("f297dbcba7a2d0bb");

// Verify.

assertFalse(

@@ -471,7 +471,7 @@ public class MinidumpUploadServiceTest extends CrashTestCase {

// Run test.

MinidumpUploadService service = new TestMinidumpUploadService(context);

- service.tryUploadCrashDumpWithLocalId("f297dbcba7a2d0bb");

+ service.tryUploadCrashDumpWithLocalIdImpl("f297dbcba7a2d0bb");

// Verify.

assertFalse(