Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2324923002: Remove OnSuspend/OnResume notifications on Android. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
nyquist, agrieve
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OnSuspend/OnResume notifications on Android. These are incorrectly mixing disparate concepts. Chrome code expects OnSuspend/OnResume to mean the system is about to go to sleep, not just that there is no more visible activity. This prevents background tasks like background audio from working properly since the network connections are force killed. We could workaround this by improving when OnSuspend/OnResume is sent, but it seems no one really cares, so just delete these. In fact a couple pieces of code explicitly reject OnSupend/OnResume from Android since they do not mean what is expected. An alternate signal for app suspension should be sent if this is ever needed again in the future. BUG=644515 TEST=background audio playback works. Committed: https://crrev.com/610004f26299d1eb31b18f7dce3e2d3740eb8c04 Cr-Commit-Position: refs/heads/master@{#417691}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -52 lines) Patch
M base/android/java/src/org/chromium/base/PowerMonitor.java View 4 chunks +1 line, -27 lines 0 comments Download
M base/power_monitor/power_monitor_device_source_android.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/peer_connection_tracker_unittest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
DaleCurtis
4 years, 3 months ago (2016-09-08 20:03:13 UTC) #2
DaleCurtis
nyquist seems OOO, +agrieve
4 years, 3 months ago (2016-09-09 20:07:47 UTC) #10
agrieve
On 2016/09/09 20:07:47, DaleCurtis wrote: > nyquist seems OOO, +agrieve lgtm
4 years, 3 months ago (2016-09-09 20:20:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324923002/20001
4 years, 3 months ago (2016-09-09 20:23:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 20:27:26 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 20:30:04 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/610004f26299d1eb31b18f7dce3e2d3740eb8c04
Cr-Commit-Position: refs/heads/master@{#417691}

Powered by Google App Engine
This is Rietveld 408576698