Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2324873002: DevTools: telemetry still assumes webviews are pages. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, android-webview-reviews_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: telemetry still assumes webviews are pages. BUG=645099 TBR=dgozman Committed: https://crrev.com/e223f2a9849208384d5e856937f0a2c1c6c54796 Cr-Commit-Position: refs/heads/master@{#417347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M android_webview/browser/aw_devtools_manager_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_devtools_manager_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pfeldman
4 years, 3 months ago (2016-09-08 17:36:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324873002/1
4 years, 3 months ago (2016-09-08 17:37:37 UTC) #5
dgozman
lgtm
4 years, 3 months ago (2016-09-08 17:46:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 18:29:32 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 18:34:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e223f2a9849208384d5e856937f0a2c1c6c54796
Cr-Commit-Position: refs/heads/master@{#417347}

Powered by Google App Engine
This is Rietveld 408576698