Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2324863002: [stubs] Factor CSA::GrowElementsCapacity() out of existing code. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Factor CSA::GrowElementsCapacity() out of existing code. ... and rename CheckAndGrowElementsCapacity() to TryGrowElementsCapacity(). Committed: https://crrev.com/9cf3333806842e6445e5abe82fa97116f3d04085 Cr-Commit-Position: refs/heads/master@{#39307}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -27 lines) Patch
M src/builtins/builtins-internal.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/code-stub-assembler.h View 1 1 chunk +22 lines, -5 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +34 lines, -13 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-08 18:14:39 UTC) #4
Jakob Kummerow
lgtm https://codereview.chromium.org/2324863002/diff/1/src/code-stub-assembler.h File src/code-stub-assembler.h (right): https://codereview.chromium.org/2324863002/diff/1/src/code-stub-assembler.h#newcode370 src/code-stub-assembler.h:370: // or bails out if the growing gap ...
4 years, 3 months ago (2016-09-09 10:49:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324863002/20001
4 years, 3 months ago (2016-09-09 11:54:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 12:21:27 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 12:22:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9cf3333806842e6445e5abe82fa97116f3d04085
Cr-Commit-Position: refs/heads/master@{#39307}

Powered by Google App Engine
This is Rietveld 408576698