[parser] Refactor of Parse*Statement*, part 6

[parser] Refactor of Parse*Statement*, part 6

This patch moves the following parsing method to ParserBase:

- ParseSwitchStatement

It also removes ParseCaseClause and merges it with ParseSwitchStatement,
mainly to avoid the complexity of introducing one more abstract typedef
to be shared between parser implementations, but also because the merged
ParseSwitchStatement is now only 59 lines.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/e850ed2a1e077b41e2a8a7bb9a6b8a838a0be438
Cr-Commit-Position: refs/heads/master@{#39337}

[adamk, 2016-09-09 17:59:12]

lgtm % nits

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1780: BlockT switch_block = factory()->NewBlock(NULL, 2,
false, kNoSourcePosition);
s/BlockT/Block*/

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1799: ExpressionT tag_read =
factory()->NewVariableProxy(tag_variable);
and here

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1801: BlockT cases_block = factory()->NewBlock(NULL, 1,
false, kNoSourcePosition);
and here

[nickie, 2016-09-10 18:13:12]

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1780: BlockT switch_block = factory()->NewBlock(NULL, 2,
false, kNoSourcePosition);
On 2016/09/09 17:59:12, adamk wrote:
> s/BlockT/Block*/

Done.

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1799: ExpressionT tag_read =
factory()->NewVariableProxy(tag_variable);
On 2016/09/09 17:59:12, adamk wrote:
> and here

Done.

https://codereview.chromium.org/2324843005/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1801: BlockT cases_block = factory()->NewBlock(NULL, 1,
false, kNoSourcePosition);
On 2016/09/09 17:59:12, adamk wrote:
> and here

Done.

[nickie, 2016-09-10 18:18:51]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 18:18:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 18:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 18:43:08]

Dry run: This issue passed the CQ dry run.

[marja, 2016-09-12 08:17:56]

https://codereview.chromium.org/2324843005/diff/60001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2324843005/diff/60001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1757: Statement* Parser::ParseFunctionDeclaration(bool*
ok) {
Hmm, why did you add this code?

[nickie, 2016-09-12 09:03:37]

https://codereview.chromium.org/2324843005/diff/60001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2324843005/diff/60001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1757: Statement* Parser::ParseFunctionDeclaration(bool*
ok) {
On 2016/09/12 08:17:56, marja wrote:
> Hmm, why did you add this code?

I did not add it, it's in the left column in line 1715.  I think it just moved
while merging; let me try to move it back... :-)

[marja, 2016-09-12 09:06:42]

lgtm (since adamk@ already reviewed, I didn't read through this in detail)

[nickie, 2016-09-12 09:12:33]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-09-12 09:12:33]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2324843005/#ps80001
(title: "Reorder methods")

[commit-bot: I haz the power, 2016-09-12 09:12:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 09:39:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-12 09:39:59]

Description was changed from

==========
[parser] Refactor of Parse*Statement*, part 6

This patch moves the following parsing method to ParserBase:

- ParseSwitchStatement

It also removes ParseCaseClause and merges it with ParseSwitchStatement,
mainly to avoid the complexity of introducing one more abstract typedef
to be shared between parser implementations, but also because the merged
ParseSwitchStatement is now only 59 lines.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Refactor of Parse*Statement*, part 6

This patch moves the following parsing method to ParserBase:

- ParseSwitchStatement

It also removes ParseCaseClause and merges it with ParseSwitchStatement,
mainly to avoid the complexity of introducing one more abstract typedef
to be shared between parser implementations, but also because the merged
ParseSwitchStatement is now only 59 lines.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/e850ed2a1e077b41e2a8a7bb9a6b8a838a0be438
Cr-Commit-Position: refs/heads/master@{#39337}
==========

[commit-bot: I haz the power, 2016-09-12 09:40:01]

Patchset 5 (id:??) landed as
https://crrev.com/e850ed2a1e077b41e2a8a7bb9a6b8a838a0be438
Cr-Commit-Position: refs/heads/master@{#39337}