Define Stable API for WebRTC/Quartc

net/quic/quartc/quartc_packet_writer.cc

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/quic/quartc/quartc_packet_writer.h"
+
+namespace net {
+
+QuartcPacketWriter::QuartcPacketWriter(
+    QuartcSessionInterface::PacketTransport* packet_transport)
+    : packet_transport_(packet_transport) {}
+
+WriteResult QuartcPacketWriter::WritePacket(const char* buffer,
+                                            size_t buf_len,
+                                            const IPAddress& self_address,
+                                            const IPEndPoint& peer_address,
+                                            PerPacketOptions* options) {
+  DCHECK(packet_transport_);
+  int bytes_written = packet_transport_->Write(buffer, buf_len);
+  if (bytes_written <= 0) {
+    return WriteResult(WRITE_STATUS_BLOCKED, EWOULDBLOCK);
+  }
+  return WriteResult(WRITE_STATUS_OK, bytes_written);
+}
+
+bool QuartcPacketWriter::IsWriteBlockedDataBuffered() const {
+  return false;
+}
+
+bool QuartcPacketWriter::IsWriteBlocked() const {
+  DCHECK(packet_transport_);
+  return !packet_transport_->CanWrite();
+}
+
+// TODO(zhihuang) To figure out what is the better value to return. The

[pthatcher1, 2016/10/14 18:59:00]

"To figure out" => Figure out

[zhihuang1, 2016/10/16 00:45:28]

Done.

+// transport in WebRTC network layer may become the bottleneck when determining
+// the MTU.

[pthatcher1, 2016/10/14 18:59:00]

We should probably make this an option in the QuartcFactoryConfig with this as
the default so that WebRTC (or other users) can set it without updating the QUIC
code.

[zhihuang1, 2016/10/16 00:45:28]

Agreed. This is a good point.

Because the PacketTransport related stuff is in QuartcSessionInterface, I think
it would make sense for max_packet_size to be part of QuartcSessionConfig.

+QuicByteCount QuartcPacketWriter::GetMaxPacketSize(
+    const IPEndPoint& peer_address) const {
+  return kMaxPacketSize;
+}
+
+void QuartcPacketWriter::SetWritable() {}
+
+}  // namespace net