Define Stable API for WebRTC/Quartc

net/quic/quartc/quartc_factory.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_QUIC_QUARTC_QUARTC_FACTORY_H_
+#define NET_QUIC_QUARTC_QUARTC_FACTORY_H_
+
+#include "net/quic/core/quic_connection.h"
+#include "net/quic/quartc/quartc_alarm_factory.h"
+#include "net/quic/quartc/quartc_connection_helper.h"
+#include "net/quic/quartc/quartc_factory_interface.h"
+#include "net/quic/quartc/quartc_packet_writer.h"
+
+namespace net {
+
+class QuartcFactory : public QuartcFactoryInterface {

[Ryan Hamilton, 2016/10/10 19:48:30]

class comment, please.

+ public:
+  QuartcFactory();
+  ~QuartcFactory() override;
+
+  std::unique_ptr<QuartcSessionInterface> CreateQuartcSession(
+      const QuartcConfig& quartc_config) override;
+
+ private:
+  std::unique_ptr<QuicConnection> CreateQuicConnection(
+      const QuartcConfig& quartc_config,
+      Perspective perspective);
+
+  std::unique_ptr<QuartcAlarmFactory> alarm_factory_;
+  std::unique_ptr<QuicConfig> config_;

[pthatcher2, 2016/10/05 22:12:05]

This could use a comment also.  For example, where does the config come from,
and what effect does it have?

[pthatcher2, 2016/10/05 22:12:05]

Should this be quic_config_ to make it clear that it's not a QuartcConfig?

[zhihuang1, 2016/10/13 06:22:39]

Agreed.

+  std::unique_ptr<QuartcConnectionHelper> helper_;

[pthatcher2, 2016/10/05 22:12:05]

Why do we have the QuartcConnetionHelper owned by the QuartcFactory?  Why not
just make the QuartcFactory be the QuartcConnectionHelper (own the clock and
buffer allocator)?  It already owns the QuartcAlarmFactory.

+};
+
+}  // namepapce net
+
+#endif  // NET_QUIC_QUARTC_QUARTC_FACTORY_H_