Define Stable API for WebRTC/Quartc

net/quic/quartc/quartc_alarm_factory.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_QUIC_QUARTC_QUARTC_ALARM_FACTORY_H_
+#define NET_QUIC_QUARTC_QUARTC_ALARM_FACTORY_H_
+
+#include <utility>
+
+#include "net/quic/core/quic_alarm_factory.h"
+#include "net/quic/core/quic_clock.h"
+
+namespace base {
+class TaskRunner;
+}  // namespace base
+
+namespace net {
+
+class NET_EXPORT_PRIVATE QuartcAlarmFactory : public QuicAlarmFactory {

[pthatcher2, 2016/10/05 22:12:04]

Can you add a comment on the class?  Something that explain why it's needed
would be nice.

[zhihuang1, 2016/10/13 06:22:39]

Done.

+ public:
+  QuartcAlarmFactory(base::TaskRunner* task_runner, const QuicClock* clock);
+  ~QuartcAlarmFactory() override;
+
+  QuicAlarm* CreateAlarm(QuicAlarm::Delegate* delegate) override;
+
+  QuicArenaScopedPtr<QuicAlarm> CreateAlarm(
+      QuicArenaScopedPtr<QuicAlarm::Delegate> delegate,
+      QuicConnectionArena* arena) override;
+
+ private:
+  base::TaskRunner* task_runner_;
+  const QuicClock* clock_;

[Ryan Hamilton, 2016/10/10 19:48:30]

nit: Can you comment on ownership? (I assume both of these are unowned)

[zhihuang1, 2016/10/13 06:22:39]

Done.

+  //  QuartcAlarmFactoryObserver* factory_observer_ = nullptr;

[pthatcher2, 2016/10/05 22:12:04]

Should this be deleted?

[zhihuang1, 2016/10/13 06:22:39]

Done.

+  DISALLOW_COPY_AND_ASSIGN(QuartcAlarmFactory);
+};
+
+}  // namespace net
+
+#endif  // NET_QUIC_QUARTC_QUARTC_ALARM_FACTORY_H_