Define Stable API for WebRTC/Quartc

net/quic/quartc/quartc_factory_interface.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_QUIC_QUARTC_QUARTC_FACTORY_INTERFACE_H_
+#define NET_QUIC_QUARTC_QUARTC_FACTORY_INTERFACE_H_
+
+#include "net/quic/quartc/quartc_session_interface.h"
+
+namespace net {
+class QuartcFactoryInterface {

[Ryan Hamilton, 2016/09/23 19:56:43]

nit: comments and newlines, please.

[zhihuang1, 2016/09/24 06:54:05]

Done.

+ public:
+  struct QuartcConfig {
+    // Used to determine the perspective of the session.
+    bool is_server = false;
+    // Used for creating a unique server ID. Only used by the client side.

[Ryan Hamilton, 2016/09/23 19:56:43]

The phrasing of this comment is confused to me, but of course I don't actually
know WebRTC. If this string is used to create a server ID I would have expected
it to be used by the server not the client. Can you say more?

[zhihuang1, 2016/09/24 06:54:05]

Done.

+    std::string remote_fingerprint_value;
+    // Used for creating a QuartcPacketWriter for QuicConnection which is
+    // required when creating a QuartcSession.
+    QuartcSessionInterface::Transport* transport = nullptr;
+  };
+
+  virtual std::unique_ptr<QuartcSessionInterface> CreateQuartcSession(
+      const QuartcConfig& quartc_config) = 0;

[Ryan Hamilton, 2016/09/23 19:56:43]

Can you comment on the ownership of quartc_config.transport? Presumably it's
still owned by the caller.

[zhihuang1, 2016/09/24 06:54:05]

Done.

+};
+
+// Creates a new instance of QuartcFactoryInterface.
+std::unique_ptr<QuartcFactoryInterface> CreateQuartcFactory();
+
+}  // namepace net
+
+#endif  // NET_QUIC_QUARTC_QUARTC_FACTORY_INTERFACE_H_