Define Stable API for WebRTC/Quartc

net/quic/quartc/quartc_connection_helper.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_QUIC_QUARTC_QUARTC_CONNECTION_HELPER_H_
+#define NET_QUIC_QUARTC_QUARTC_CONNECTION_HELPER_H_
+
+#include "net/quic/core/crypto/quic_random.h"
+#include "net/quic/core/quic_alarm.h"
+#include "net/quic/core/quic_alarm_factory.h"

[skvlad-chromium, 2016/09/22 01:54:25]

Are these two includes necessary?

[zhihuang1, 2016/09/22 18:53:52]

No, these should be removed.

+#include "net/quic/core/quic_clock.h"
+#include "net/quic/core/quic_connection.h"
+#include "net/quic/core/quic_simple_buffer_allocator.h"
+
+namespace net {
+
+// This is the helper class for Quartc to create a QuicConnection.

[skvlad-chromium, 2016/09/22 01:54:25]

The name 'Quartc' may not tell much to someone who's new to the codebase. I
think we should either include a comment into each file that clarifies that
'Quartc' is 'QUIC in WebRTC', or have a short README file in the /quartc/
directory. Not sure what fits better with the Chromium style - probably a
comment.

+class NET_EXPORT_PRIVATE QuartcConnectionHelper
+    : public QuicConnectionHelperInterface {
+ public:
+  ~QuartcConnectionHelper() override;
+  // QuicConnectionHelperInterface overrides.
+  const QuicClock* GetClock() const override;
+  QuicRandom* GetRandomGenerator() override;
+  QuicBufferAllocator* GetBufferAllocator() override;
+
+ private:
+  QuicClock clock_;
+  SimpleBufferAllocator buffer_allocator_;
+};
+
+}  // namepace net
+
+#endif  // NET_QUIC_QUARTC_QUARTC_CONNECTION_HELPER_H_