Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2324823002: Reorder protobuf compiler command line arguments. (Closed)

Created:
2 years, 7 months ago by kraynov
Modified:
2 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorder protobuf compiler command line arguments. Attempt to chase non-repoducible bug. CL crrev.com/2239383002 has changed a command line for protoc and there are rare occasional crashes on Win32. It could be because of some bug in protoc's parser. This change restores a command line like before the suspecting CL only for the most common case with only one proto file in a library. BUG=644525 Committed: https://crrev.com/e4dfc3b51a21c5c771efe6108d0e75c4239706ee Cr-Commit-Position: refs/heads/master@{#417544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M tools/protoc_wrapper/protoc_wrapper.py View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kraynov
PTAL
2 years, 7 months ago (2016-09-08 16:37:35 UTC) #3
Primiano Tucci (use gerrit)
thanks, non-owner LGTM. I can't think of any other reason why the same invocation of ...
2 years, 7 months ago (2016-09-08 16:46:42 UTC) #6
scottmg
Sorry, for the delay was out today. lgtm to try if you want, but as ...
2 years, 7 months ago (2016-09-09 04:14:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324823002/1
2 years, 7 months ago (2016-09-09 09:43:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 7 months ago (2016-09-09 09:46:49 UTC) #13
commit-bot: I haz the power
2 years, 7 months ago (2016-09-09 09:48:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4dfc3b51a21c5c771efe6108d0e75c4239706ee
Cr-Commit-Position: refs/heads/master@{#417544}

Powered by Google App Engine
This is Rietveld 408576698