cros/ash: Cancel screenshot mode if screenshot is cancelled or not taken.

cros/ash: Cancel screenshot mode if screenshot is cancelled or not taken.

TEST=ash_unittests
BUG=645277
Committed: https://crrev.com/53bbe593bc5ffc9e5b3e130bf828adb54c52ac4a
Cr-Commit-Position: refs/heads/master@{#419534}

[jdufault, 2016-09-08 22:09:22]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 22:10:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-09-08 22:36:32]

Description was changed from

==========
Cancel screenshot mode if screenshot is cancelled or not taken.

BUG=
==========

to

==========
cros/ash: Cancel screenshot mode if screenshot is cancelled or not taken.

TEST=ash_unittests
BUG=645277
==========

[commit-bot: I haz the power, 2016-09-08 23:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:05:00]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-09-09 17:10:26]

jdufault@chromium.org changed reviewers:
+ oshima@chromium.org

[jdufault, 2016-09-09 17:11:13]

oshima@, PTAL. The previous approach did not work if the user either cancelled
the partial screenshot or if they captured a 0xb or ax0 region.

[jdufault, 2016-09-13 19:31:49]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 19:32:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:49:20]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-09-13 20:53:06]

ping

[oshima, 2016-09-16 20:42:25]

lgtm

https://codereview.chromium.org/2324803003/diff/20001/ash/utility/screenshot_...
File ash/utility/screenshot_controller.h (right):

https://codereview.chromium.org/2324803003/diff/20001/ash/utility/screenshot_...
ash/utility/screenshot_controller.h:62: // been completed. This is reset after
the screenshot session is done.
Can you update the comment and mention that this is called even if it's
cancelled? (completed sounds it's taken)

[oshima, 2016-09-16 20:42:26]

lgtm

[jdufault, 2016-09-16 22:57:52]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-09-16 22:57:54]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2324803003/#ps40001
(title: "Update comment")

[jdufault, 2016-09-16 22:58:05]

https://codereview.chromium.org/2324803003/diff/20001/ash/utility/screenshot_...
File ash/utility/screenshot_controller.h (right):

https://codereview.chromium.org/2324803003/diff/20001/ash/utility/screenshot_...
ash/utility/screenshot_controller.h:62: // been completed. This is reset after
the screenshot session is done.
On 2016/09/16 20:42:25, oshima wrote:
> Can you update the comment and mention that this is called even if it's
> cancelled? (completed sounds it's taken)

Done.

[commit-bot: I haz the power, 2016-09-16 22:58:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:02:54]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jdufault, 2016-09-19 18:28:03]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-09-19 18:28:04]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2324803003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-19 18:28:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:44:58]

Description was changed from

==========
cros/ash: Cancel screenshot mode if screenshot is cancelled or not taken.

TEST=ash_unittests
BUG=645277
==========

to

==========
cros/ash: Cancel screenshot mode if screenshot is cancelled or not taken.

TEST=ash_unittests
BUG=645277
==========

[commit-bot: I haz the power, 2016-09-19 19:45:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-19 21:03:12]

Description was changed from

==========
cros/ash: Cancel screenshot mode if screenshot is cancelled or not taken.

TEST=ash_unittests
BUG=645277
==========

to

==========
cros/ash: Cancel screenshot mode if screenshot is cancelled or not taken.

TEST=ash_unittests
BUG=645277

Committed: https://crrev.com/53bbe593bc5ffc9e5b3e130bf828adb54c52ac4a
Cr-Commit-Position: refs/heads/master@{#419534}
==========

[commit-bot: I haz the power, 2016-09-19 21:03:13]

Patchset 4 (id:??) landed as
https://crrev.com/53bbe593bc5ffc9e5b3e130bf828adb54c52ac4a
Cr-Commit-Position: refs/heads/master@{#419534}