Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2324803002: [Parser] Avoid on-the-fly internalization for natives_syntax. (Closed)

Created:
4 years, 3 months ago by rmcilroy
Modified:
4 years, 3 months ago
Reviewers:
ulan, marja
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Parser] Avoid on-the-fly internalization for natives_syntax. Rework Runtime::FunctionForName to take a c-string instead of a v8::String so that the parser can parse native syntax runtime calls without doing on-the-fly internalization. Also adds a c-string variant of IntrinsicIndexForName for the same reasons. BUG=v8:5215, chromium:634953 Committed: https://crrev.com/d15f45d4db96e6eb9fcdadc26be11f080845eea3 Cr-Commit-Position: refs/heads/master@{#39346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -46 lines) Patch
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/runtime/runtime.cc View 2 chunks +52 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
rmcilroy
Marja, what do you think of this approach. This, along with Jochen's "Deserialize the scope ...
4 years, 3 months ago (2016-09-08 16:27:49 UTC) #7
marja
lgtm, I think this is the right approach. (At least from the parser's point of ...
4 years, 3 months ago (2016-09-09 06:04:56 UTC) #8
rmcilroy
Ulan, PTAL at the heap changes, thanks.
4 years, 3 months ago (2016-09-09 08:14:48 UTC) #10
rmcilroy
On 2016/09/09 08:14:48, rmcilroy wrote: > Ulan, PTAL at the heap changes, thanks. Ping, Ulan ...
4 years, 3 months ago (2016-09-12 08:47:11 UTC) #11
ulan
heap lgtm
4 years, 3 months ago (2016-09-12 10:50:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324803002/1
4 years, 3 months ago (2016-09-12 10:58:12 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 11:35:45 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 11:36:08 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d15f45d4db96e6eb9fcdadc26be11f080845eea3
Cr-Commit-Position: refs/heads/master@{#39346}

Powered by Google App Engine
This is Rietveld 408576698