Do a better job at faking simple challenge signatures.

Do a better job at faking simple challenge signatures.

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass
TBR=xiyuan@chromium.org

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001 (http://crrev.com/2297193006#ps120001)

Committed: https://crrev.com/7da3d8b32b30123c741dfd31371e45416c680bd4
Cr-Commit-Position: refs/heads/master@{#417509}

[The one and only Dr. Crash, 2016-09-08 23:07:08]

Description was changed from

==========
Do a better job at faking simple challenge signatures.

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as
SignedData, we allow callers of the FakeCryptohomeClient to extract the original
data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the
FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001
(http://crrev.com/2297193006#ps120001)
==========

to

==========
Do a better job at faking simple challenge signatures.

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as
SignedData, we allow callers of the FakeCryptohomeClient to extract the original
data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the
FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass
TBR=xiyuan@chromium.org

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001
(http://crrev.com/2297193006#ps120001)
==========

[The one and only Dr. Crash, 2016-09-08 23:07:17]

drcrash@chromium.org changed reviewers:
+ achuith@chromium.org

[The one and only Dr. Crash, 2016-09-08 23:09:12]

drcrash@chromium.org changed reviewers:
+ achuith@google.com
- achuith@chromium.org

[The one and only Dr. Crash, 2016-09-08 23:09:13]

Fixed includes to refer to chromeos/attestation/attestation.pb.h instead of the
old attestation_signed_data.pb.h in another location, plus a couple minor
warnings issued by git cl lint while I was at it.

Checked with a brand new build directory by building all targets affected
(chrome, unit_tests, chromeos_unittests, and browser_tests for good measure).

[The one and only Dr. Crash, 2016-09-08 23:09:21]

drcrash@chromium.org changed reviewers:
+ achuith@chromium.org
- achuith@google.com

[achuithb, 2016-09-08 23:10:43]

achuith@chromium.org changed reviewers:
+ xiyuan@chromium.org

[achuithb, 2016-09-08 23:10:44]

Since I'm unfamiliar with the original CL, I think Xiyuan would be more
efficient at reviewing this.

[The one and only Dr. Crash, 2016-09-08 23:17:20]

I put him as a TBR. But if you look at the diffs between base and patchsets
1/2 you'll see it's a trivial replacement of one include (with the old
location) by another one(the new).

On Thu, Sep 8, 2016 at 4:10 PM, <achuith@chromium.org> wrote:

> Since I'm unfamiliar with the original CL, I think Xiyuan would be more
> efficient at reviewing this.
>
> https://codereview.chromium.org/2324793003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[achuithb, 2016-09-09 00:26:40]

lgtm

[The one and only Dr. Crash, 2016-09-09 00:46:13]

The CQ bit was checked by drcrash@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:46:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:57:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:57:45]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[The one and only Dr. Crash, 2016-09-09 04:30:13]

The CQ bit was checked by drcrash@chromium.org

[commit-bot: I haz the power, 2016-09-09 04:30:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 05:40:42]

Description was changed from

==========
Do a better job at faking simple challenge signatures.

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as
SignedData, we allow callers of the FakeCryptohomeClient to extract the original
data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the
FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass
TBR=xiyuan@chromium.org

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001
(http://crrev.com/2297193006#ps120001)
==========

to

==========
Do a better job at faking simple challenge signatures.

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as
SignedData, we allow callers of the FakeCryptohomeClient to extract the original
data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the
FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass
TBR=xiyuan@chromium.org

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001
(http://crrev.com/2297193006#ps120001)
==========

[commit-bot: I haz the power, 2016-09-09 05:40:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-09 05:44:49]

Description was changed from

==========
Do a better job at faking simple challenge signatures.

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as
SignedData, we allow callers of the FakeCryptohomeClient to extract the original
data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the
FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass
TBR=xiyuan@chromium.org

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001
(http://crrev.com/2297193006#ps120001)
==========

to

==========
Do a better job at faking simple challenge signatures.

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as
SignedData, we allow callers of the FakeCryptohomeClient to extract the original
data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the
FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass
TBR=xiyuan@chromium.org

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001
(http://crrev.com/2297193006#ps120001)

Committed: https://crrev.com/7da3d8b32b30123c741dfd31371e45416c680bd4
Cr-Commit-Position: refs/heads/master@{#417509}
==========

[commit-bot: I haz the power, 2016-09-09 05:44:50]

Patchset 3 (id:??) landed as
https://crrev.com/7da3d8b32b30123c741dfd31371e45416c680bd4
Cr-Commit-Position: refs/heads/master@{#417509}