Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: src/ast/scopes.h

Issue 2324783002: Include only stuff you need, part 9: variables.h (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/ast/scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 8ffa0005b03c0a248813c6c8e41c0f61200c5e23..0c10633e02fdc387cd7e238dafe9b98839b82744 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -5,9 +5,9 @@
#ifndef V8_AST_SCOPES_H_
#define V8_AST_SCOPES_H_
-#include "src/ast/variables.h"
#include "src/base/hashmap.h"
#include "src/globals.h"
+#include "src/objects.h"
#include "src/zone.h"
namespace v8 {
@@ -19,6 +19,7 @@ class AstRawString;
class Declaration;
class ParseInfo;
class SloppyBlockFunctionStatement;
+class StringSet;
class VariableProxy;
// A hash map to support fast variable declaration and lookup.
@@ -27,7 +28,7 @@ class VariableMap: public ZoneHashMap {
explicit VariableMap(Zone* zone);
Variable* Declare(Zone* zone, Scope* scope, const AstRawString* name,
- VariableMode mode, Variable::Kind kind,
+ VariableMode mode, VariableKind kind,
InitializationFlag initialization_flag,
MaybeAssignedFlag maybe_assigned_flag = kNotAssigned,
bool* added = nullptr);
@@ -140,7 +141,7 @@ class Scope: public ZoneObject {
// Declare a local variable in this scope. If the variable has been
// declared before, the previously declared variable is returned.
Variable* DeclareLocal(const AstRawString* name, VariableMode mode,
- InitializationFlag init_flag, Variable::Kind kind,
+ InitializationFlag init_flag, VariableKind kind,
MaybeAssignedFlag maybe_assigned_flag = kNotAssigned);
Variable* DeclareVariable(Declaration* declaration, VariableMode mode,
@@ -159,7 +160,7 @@ class Scope: public ZoneObject {
const AstRawString* name,
int start_position = kNoSourcePosition,
int end_position = kNoSourcePosition,
- Variable::Kind kind = Variable::NORMAL);
+ VariableKind kind = NORMAL_VARIABLE);
void AddUnresolved(VariableProxy* proxy);
@@ -415,7 +416,7 @@ class Scope: public ZoneObject {
private:
Variable* Declare(Zone* zone, Scope* scope, const AstRawString* name,
- VariableMode mode, Variable::Kind kind,
+ VariableMode mode, VariableKind kind,
InitializationFlag initialization_flag,
MaybeAssignedFlag maybe_assigned_flag = kNotAssigned) {
bool added;
@@ -649,7 +650,7 @@ class DeclarationScope : public Scope {
// scope) by a reference to an unresolved variable with no intervening
// with statements or eval calls.
Variable* DeclareDynamicGlobal(const AstRawString* name,
- Variable::Kind variable_kind);
+ VariableKind variable_kind);
// The variable corresponding to the 'this' value.
Variable* receiver() {
« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/ast/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698