Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2324783002: Include only stuff you need, part 9: variables.h (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include only stuff you need, part 9: variables.h TBR=bmeurer@chromium.org BUG=v8:5294 Committed: https://crrev.com/e34dfe04ea2467c7595b218d03f0d1554c0d1a14 Cr-Commit-Position: refs/heads/master@{#39304}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -101 lines) Patch
M src/ast/ast.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/ast/ast.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast/context-slot-cache.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/context-slot-cache.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/ast/prettyprinter.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/ast/scopeinfo.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopes.h View 1 2 7 chunks +7 lines, -6 lines 0 comments Download
M src/ast/scopes.cc View 1 2 18 chunks +27 lines, -31 lines 0 comments Download
M src/ast/variables.h View 1 2 5 chunks +12 lines, -22 lines 0 comments Download
M src/ast/variables.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M src/compiler/osr.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/typing.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/crankshaft/typing.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M src/parsing/parser.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 2 6 chunks +7 lines, -8 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
marja
mstarzinger, wdyt?
4 years, 3 months ago (2016-09-09 09:10:06 UTC) #10
Michael Starzinger
LGTM.
4 years, 3 months ago (2016-09-09 09:26:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324783002/40001
4 years, 3 months ago (2016-09-09 09:32:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23680)
4 years, 3 months ago (2016-09-09 09:36:06 UTC) #17
titzer
On 2016/09/09 09:36:06, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-09 10:52:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324783002/40001
4 years, 3 months ago (2016-09-09 10:53:34 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-09 10:55:39 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 10:56:00 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e34dfe04ea2467c7595b218d03f0d1554c0d1a14
Cr-Commit-Position: refs/heads/master@{#39304}

Powered by Google App Engine
This is Rietveld 408576698