Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2324763003: [SyzyASAN] Add support for LODS instruction. (Closed)

Created:
4 years, 3 months ago by chrisha
Modified:
4 years, 3 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

[SyzyASAN] Add support for LODS instruction. This is breaking on the current win-asan and LKGR continuous builders. BUG=https://crbug.com/644608 R=sebmarchand@chromium.org Committed: https://github.com/google/syzygy/commit/f10f8a119b48137b6f10fc1e85abd257cc32c1ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -94 lines) Patch
M syzygy/agent/asan/gen/memory_interceptors_impl.asm View 25 chunks +322 lines, -46 lines 0 comments Download
M syzygy/agent/asan/gen/memory_redirectors.asm View 2 chunks +18 lines, -0 lines 0 comments Download
M syzygy/agent/asan/gen/system_interceptors.def View 2 chunks +8 lines, -0 lines 0 comments Download
M syzygy/agent/asan/generate_memory_interceptors.py View 1 chunk +6 lines, -0 lines 0 comments Download
M syzygy/agent/asan/memory_interceptors.h View 1 chunk +25 lines, -19 lines 0 comments Download
M syzygy/agent/asan/rtl_unittest.cc View 5 chunks +25 lines, -26 lines 0 comments Download
M syzygy/agent/asan/syzyasan_rtl.def.template View 2 chunks +8 lines, -0 lines 0 comments Download
M syzygy/agent/memprof/memory_interceptors.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M syzygy/agent/memprof/memprof.def View 2 chunks +8 lines, -0 lines 0 comments Download
M syzygy/instrument/transforms/asan_transform.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M syzygy/instrument/transforms/asan_transform_unittest.cc View 7 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
chrisha
PTAL?
4 years, 3 months ago (2016-09-08 17:08:17 UTC) #2
Sébastien Marchand
lgtm
4 years, 3 months ago (2016-09-08 17:14:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324763003/1
4 years, 3 months ago (2016-09-08 17:14:09 UTC) #5
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 3 months ago (2016-09-08 17:43:06 UTC) #7
Sigurður Ásgeirsson
Wow, what a PITA. I don't understand where REP LODS would be useful - is ...
4 years, 3 months ago (2016-09-08 18:36:34 UTC) #9
chrisha
On 2016/09/08 18:36:34, Sigurður Ásgeirsson wrote: > Wow, what a PITA. > I don't understand ...
4 years, 3 months ago (2016-09-08 19:06:50 UTC) #10
chrisha
4 years, 3 months ago (2016-09-08 20:55:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f10f8a119b48137b6f10fc1e85abd257cc32c1ab.

Powered by Google App Engine
This is Rietveld 408576698