Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2324763002: Worker: Remove WorkerThread::terminated() (Closed)

Created:
4 years, 3 months ago by nhiroki
Modified:
4 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, shimazu+worker_chromium.org, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Remove WorkerThread::terminated() Checking WorkerThread::m_threadState is a proper way to confirm whether a worker thread is initialized. BUG=639153 Committed: https://crrev.com/2276d72486293b7b1c755a1b960da2c2503bf6bc Cr-Commit-Position: refs/heads/master@{#417252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
nhiroki
Hi yhirano@, can you review this? This is extracted from https://codereview.chromium.org/2280523002/ because it needs more ...
4 years, 3 months ago (2016-09-08 09:45:59 UTC) #4
yhirano
lgtm
4 years, 3 months ago (2016-09-08 10:13:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324763002/1
4 years, 3 months ago (2016-09-08 10:45:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 11:16:58 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:18:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2276d72486293b7b1c755a1b960da2c2503bf6bc
Cr-Commit-Position: refs/heads/master@{#417252}

Powered by Google App Engine
This is Rietveld 408576698