scripts/slave/recipe_modules/chromite/api.py - Issue 2324733005: BuildBucket recipe module can expose properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromite/api.py

Issue 2324733005: BuildBucket recipe module can expose properties. (Closed)

Patch Set: Unused import. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromite/api.py

diff --git a/scripts/slave/recipe_modules/chromite/api.py b/scripts/slave/recipe_modules/chromite/api.py

index 43482d2049bf61d51dea4f5c14a6e4f96d4fc6bf..db25c1ec2978ffe01d68b472a5d33b869e7f290c 100644

--- a/scripts/slave/recipe_modules/chromite/api.py

+++ b/scripts/slave/recipe_modules/chromite/api.py

@@ -70,9 +70,9 @@ class ChromiteApi(recipe_api.RecipeApi):

if 'buildnumber' in self.m.properties:

defaults['CBB_BUILD_NUMBER'] = int(self.m.properties['buildnumber'])

- if 'buildbucket' in self.m.properties:

- buildbucket_json = self.m.json.loads(self.m.properties.get('buildbucket'))

- defaults['CBB_BUILDBUCKET_ID'] = buildbucket_json['build']['id']

+ buildbucket_props = self.m.buildbucket.properties

+ if buildbucket_props:

+ defaults['CBB_BUILDBUCKET_ID'] = buildbucket_props['build']['id']

return defaults