Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2324733005: BuildBucket recipe module can expose properties. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
Sergey Berezin, nxia1
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

BuildBucket recipe module can expose properties. Provide an API for the "buildbucket" recipe module to expose its BuildBucket properties object as a frozen dictionary. This will let recipes that need to access data embedded in those properties to have a more consistent experience accessing that data. BUG=chromium:627996 TEST=expectations Committed: https://chromium.googlesource.com/chromium/tools/build/+/4624ed2c44f81e5105bf8faf770ed47b2619e32e

Patch Set 1 #

Total comments: 4

Patch Set 2 : Unused import. #

Total comments: 1

Patch Set 3 : Remove parenthesis. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M scripts/slave/recipe_modules/buildbucket/api.py View 1 2 3 chunks +16 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/buildbucket/example.py View 2 chunks +5 lines, -0 lines 0 comments Download
A + scripts/slave/recipe_modules/buildbucket/example.expected/no_properties.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M scripts/slave/recipe_modules/chromite/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromite/api.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nxia1
lgtm https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_modules/buildbucket/api.py File scripts/slave/recipe_modules/buildbucket/api.py (right): https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_modules/buildbucket/api.py#newcode15 scripts/slave/recipe_modules/buildbucket/api.py:15: from recipe_engine import recipe_api, types is the 'types' ...
4 years, 3 months ago (2016-09-09 18:41:48 UTC) #2
nxia1
lgtm
4 years, 3 months ago (2016-09-09 18:41:50 UTC) #3
dnj
https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_modules/buildbucket/api.py File scripts/slave/recipe_modules/buildbucket/api.py (right): https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_modules/buildbucket/api.py#newcode15 scripts/slave/recipe_modules/buildbucket/api.py:15: from recipe_engine import recipe_api, types On 2016/09/09 18:41:47, nxia1 ...
4 years, 3 months ago (2016-09-09 18:50:55 UTC) #4
nxia1
lgtm
4 years, 3 months ago (2016-09-09 22:55:34 UTC) #5
nxia1
can we submit this CL?
4 years, 3 months ago (2016-09-12 17:48:56 UTC) #6
dnj
PTAL
4 years, 3 months ago (2016-09-13 20:44:36 UTC) #8
Sergey Berezin
LGTM + nit https://codereview.chromium.org/2324733005/diff/20001/scripts/slave/recipe_modules/buildbucket/api.py File scripts/slave/recipe_modules/buildbucket/api.py (right): https://codereview.chromium.org/2324733005/diff/20001/scripts/slave/recipe_modules/buildbucket/api.py#newcode44 scripts/slave/recipe_modules/buildbucket/api.py:44: buildbucket_info = (self.properties or {}) nit: ...
4 years, 3 months ago (2016-09-13 20:55:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324733005/40001
4 years, 3 months ago (2016-09-13 21:06:41 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 21:10:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/4624ed2c44f81e5105bf...

Powered by Google App Engine
This is Rietveld 408576698