BuildBucket recipe module can expose properties.

BuildBucket recipe module can expose properties.

Provide an API for the "buildbucket" recipe module to expose its
BuildBucket properties object as a frozen dictionary. This will let
recipes that need to access data embedded in those properties to have a
more consistent experience accessing that data.

BUG=chromium:627996
TEST=expectations

Committed: https://chromium.googlesource.com/chromium/tools/build/+/4624ed2c44f81e5105bf8faf770ed47b2619e32e

[nxia1, 2016-09-09 18:41:47]

nxia@google.com changed reviewers:
+ nxia@google.com

[nxia1, 2016-09-09 18:41:48]

lgtm

https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/buildbucket/api.py (right):

https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/buildbucket/api.py:15: from recipe_engine import
recipe_api, types
is the 'types' used here?

https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/buildbucket/api.py:67: if props is not None:
set _properties to {} if props is None?

[nxia1, 2016-09-09 18:41:50]

lgtm

[dnj, 2016-09-09 18:50:55]

https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/buildbucket/api.py (right):

https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/buildbucket/api.py:15: from recipe_engine import
recipe_api, types
On 2016/09/09 18:41:47, nxia1 wrote:
> is the 'types' used here?

oops, nope

https://codereview.chromium.org/2324733005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/buildbucket/api.py:67: if props is not None:
On 2016/09/09 18:41:48, nxia1 wrote:
> set _properties to {} if props is None?

I want it to return None to differentiate "no properties" from empty properties.

[nxia1, 2016-09-09 22:55:34]

lgtm

[nxia1, 2016-09-12 17:48:56]

can we submit this CL?

[dnj, 2016-09-13 20:44:36]

dnj@chromium.org changed reviewers:
+ sergeyberezin@chromium.org

[dnj, 2016-09-13 20:44:36]

PTAL

[Sergey Berezin, 2016-09-13 20:55:49]

LGTM + nit

https://codereview.chromium.org/2324733005/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/buildbucket/api.py (right):

https://codereview.chromium.org/2324733005/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/buildbucket/api.py:44: buildbucket_info =
(self.properties or {})
nit: no need for parentheses.

[dnj, 2016-09-13 21:06:30]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-09-13 21:06:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, nxia@google.com
Link to the patchset: https://codereview.chromium.org/2324733005/#ps40001
(title: "Remove parenthesis.")

[commit-bot: I haz the power, 2016-09-13 21:06:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 21:10:38]

Description was changed from

==========
BuildBucket recipe module can expose properties.

Provide an API for the "buildbucket" recipe module to expose its
BuildBucket properties object as a frozen dictionary. This will let
recipes that need to access data embedded in those properties to have a
more consistent experience accessing that data.

BUG=chromium:627996
TEST=expectations
==========

to

==========
BuildBucket recipe module can expose properties.

Provide an API for the "buildbucket" recipe module to expose its
BuildBucket properties object as a frozen dictionary. This will let
recipes that need to access data embedded in those properties to have a
more consistent experience accessing that data.

BUG=chromium:627996
TEST=expectations

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/4624ed2c44f81e5105bf...
==========

[commit-bot: I haz the power, 2016-09-13 21:10:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/4624ed2c44f81e5105bf...