Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2324733004: Reland: Video capture Android: enable unittests for Camera2 API (Closed)

Created:
4 years, 3 months ago by mcasas
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Video capture Android: enable unittests for Camera2 API [wip] The original CL was reverted due to breaking, among others, WebViewLayoutTest#testMediaStreamApi and MediaAccessPermissionRequestTest#testGrantAccess Original CL description ------------------------------------------------ Video capture Android: enable unittests for Camera2 API This CL reenables a bunch of VideoCaptureDeviceTest test cases for Android and for the "new" APIs For this: - adds a |mTestMode| to VideoCapture.java, interface of all camera java classes. VCCamera2.java tests this flag and adds a capture thread if it's set. - the C++ correspondent classes get a method to configure the java side for testing, and a method to test if the underlying platform is using the new or the old APIs. Also: - Removes DeAllocateCameraWhileRunning because it was equivalent to CaptureWithSize test case. - Cleans up/refactors some parts of the unit tests, adds a few more comments etc BUG=626857 TBR=emircan@chromium.org, trivial change. ------------------------------------------------------------------------- TEST= ninja -C out/Release android_webview_test_apk && out/Release/bin/run_android_webview_test_apk -f MediaAccessPermissionRequestTest.* fails in PS1, works in PS2 Committed: https://crrev.com/d6f5c9810a058d5c2a5db7589f39c54dad230f6a Cr-Commit-Position: refs/heads/master@{#417619}

Patch Set 1 : verbatim https://codereview.chromium.org/2286303003/ #

Patch Set 2 : Do not enumerate PIXEL_FORMAT_UNKNOWN capabilities, add TODO #

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324733004/20001
4 years, 3 months ago (2016-09-09 16:30:44 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 17:39:56 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 17:44:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6f5c9810a058d5c2a5db7589f39c54dad230f6a
Cr-Commit-Position: refs/heads/master@{#417619}

Powered by Google App Engine
This is Rietveld 408576698