Chromium Code Reviews
DescriptionReland: Video capture Android: enable unittests for Camera2 API
[wip]
The original CL was reverted due to breaking, among others,
WebViewLayoutTest#testMediaStreamApi and
MediaAccessPermissionRequestTest#testGrantAccess
Original CL description ------------------------------------------------
Video capture Android: enable unittests for Camera2 API
This CL reenables a bunch of VideoCaptureDeviceTest
test cases for Android and for the "new" APIs
For this:
- adds a |mTestMode| to VideoCapture.java, interface
of all camera java classes. VCCamera2.java tests this
flag and adds a capture thread if it's set.
- the C++ correspondent classes get a method to configure
the java side for testing, and a method to test if the
underlying platform is using the new or the old APIs.
Also:
- Removes DeAllocateCameraWhileRunning because it was
equivalent to CaptureWithSize test case.
- Cleans up/refactors some parts of the unit tests, adds
a few more comments etc
BUG=626857
TBR=emircan@chromium.org, trivial change.
-------------------------------------------------------------------------
TEST= ninja -C out/Release android_webview_test_apk &&
out/Release/bin/run_android_webview_test_apk -f
MediaAccessPermissionRequestTest.*
fails in PS1, works in PS2
Committed: https://crrev.com/d6f5c9810a058d5c2a5db7589f39c54dad230f6a
Cr-Commit-Position: refs/heads/master@{#417619}
Patch Set 1 : verbatim https://codereview.chromium.org/2286303003/ #Patch Set 2 : Do not enumerate PIXEL_FORMAT_UNKNOWN capabilities, add TODO #Messages
Total messages: 8 (5 generated)
|