[wasm] Do not support grow_memory for asmjs modules.

[wasm] Do not support grow_memory for asmjs modules.

With this CL the AstDecoder produces an error if it encounters a
grow_memory instruction in an asmjs module. Additionally asmjs
instructions are not allowed anymore in wasm modules.

BUG=chromium:644674
R=titzer@chromium.org

Committed: https://crrev.com/685d488288a27ac6f208de59879ac7e11a5bb560
Cr-Commit-Position: refs/heads/master@{#39339}

[ahaas, 2016-09-08 07:37:58]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[ahaas, 2016-09-08 07:38:58]

ahaas@chromium.org changed reviewers:
+ bradnelson@chromium.org

[commit-bot: I haz the power, 2016-09-08 07:49:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 08:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 08:06:01]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12355)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[titzer, 2016-09-08 08:16:29]

Looks mostly good. Can you add some ast-decoder-unittest cases for failing
validation when the origin is incorrect?

https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1238: return;
No need to return here; the error will cause the main decoder loop to break.

https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1294: TFNode* node;
Factor this switch out to an inline method?

[ahaas, 2016-09-09 10:50:22]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 10:50:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-09 10:52:28]

I added tests to ast-decoder-unittest.cc

https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1238: return;
On 2016/09/08 at 08:16:29, titzer wrote:
> No need to return here; the error will cause the main decoder loop to break.

Done.

https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1294: TFNode* node;
On 2016/09/08 at 08:16:29, titzer wrote:
> Factor this switch out to an inline method?

Done.

[titzer, 2016-09-09 10:57:24]

On 2016/09/09 10:52:28, ahaas wrote:
> I added tests to ast-decoder-unittest.cc
> 
> https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc
> File src/wasm/ast-decoder.cc (right):
> 
>
https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc#new...
> src/wasm/ast-decoder.cc:1238: return;
> On 2016/09/08 at 08:16:29, titzer wrote:
> > No need to return here; the error will cause the main decoder loop to break.
> 
> Done.
> 
>
https://codereview.chromium.org/2324733002/diff/1/src/wasm/ast-decoder.cc#new...
> src/wasm/ast-decoder.cc:1294: TFNode* node;
> On 2016/09/08 at 08:16:29, titzer wrote:
> > Factor this switch out to an inline method?
> 
> Done.

lgtm

[commit-bot: I haz the power, 2016-09-09 11:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 11:04:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12434)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[ahaas, 2016-09-09 12:11:56]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 12:12:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 12:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 12:35:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[ahaas, 2016-09-12 09:50:38]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-09-12 09:50:38]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2324733002/#ps40001
(title: "Fixed a typo")

[commit-bot: I haz the power, 2016-09-12 09:50:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 10:16:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-12 10:16:55]

Description was changed from

==========
[wasm] Do not support grow_memory for asmjs modules.

With this CL the AstDecoder produces an error if it encounters a
grow_memory instruction in an asmjs module. Additionally asmjs
instructions are not allowed anymore in wasm modules.

BUG=chromium:644674
R=titzer@chromium.org
==========

to

==========
[wasm] Do not support grow_memory for asmjs modules.

With this CL the AstDecoder produces an error if it encounters a
grow_memory instruction in an asmjs module. Additionally asmjs
instructions are not allowed anymore in wasm modules.

BUG=chromium:644674
R=titzer@chromium.org

Committed: https://crrev.com/685d488288a27ac6f208de59879ac7e11a5bb560
Cr-Commit-Position: refs/heads/master@{#39339}
==========

[commit-bot: I haz the power, 2016-09-12 10:16:59]

Patchset 3 (id:??) landed as
https://crrev.com/685d488288a27ac6f208de59879ac7e11a5bb560
Cr-Commit-Position: refs/heads/master@{#39339}