Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

Issue 2324693003: Worker: Check forcible termination by WorkerThread::isForciblyTerminated() (Closed)
Patch Set: remove unnecessary header inclusion Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
index 3a96e9bfc98a93d0b31babdca39218ff0dd2ac78..f9f6886d1e5ee1d55c5c465c5d3550e583667bd9 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
@@ -348,6 +348,7 @@ TEST_F(WorkerThreadTest, StartAndTerminateOnScriptLoaded_TerminateWhileDebuggerT
m_mockWorkerReportingProxy->waitUntilScriptLoaded();
// Simulate that a debugger task is running.
+ // TODO(nhiroki): Run a real debugger task instead of simulation.
m_workerThread->m_runningDebuggerTask = true;
// terminate() should not schedule a force termination task because there is
@@ -370,7 +371,7 @@ TEST_F(WorkerThreadTest, StartAndTerminateOnScriptLoaded_TerminateWhileDebuggerT
// Clean up in order to satisfy DCHECK in the dtor of WorkerThread.
m_workerThread->m_runningDebuggerTask = false;
- m_workerThread->forciblyTerminateExecution();
+ m_workerThread->isolate()->TerminateExecution();
m_workerThread->waitForShutdownForTesting();
}
« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698